Skip to content

fix(di): throw if a token uses more than 20 dependencies. #6869

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

fix(di): throw if a token uses more than 20 dependencies. #6869

wants to merge 1 commit into from

Conversation

tbosch
Copy link
Contributor

@tbosch tbosch commented Feb 3, 2016

Fixes #6690

@tbosch tbosch added pr_state: LGTM action: merge The PR is ready for merge by the caretaker cla: yes and removed cla: yes labels Feb 3, 2016
@tbosch
Copy link
Contributor Author

tbosch commented Feb 3, 2016

Reviewed in person with @vsavkin

@IgorMinar IgorMinar closed this in de77700 Feb 9, 2016
@tbosch tbosch deleted the di-limit branch November 1, 2017 16:00
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DI has a limit of 20 parameters but Dart transformer does not throw an error when limit is exceeded
2 participants
@tbosch @googlebot