Skip to content

fix(ngFor): update view values manually with track by #6923

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

fix(ngFor): update view values manually with track by #6923

wants to merge 1 commit into from

Conversation

kara
Copy link
Contributor

@kara kara commented Feb 5, 2016

@vsavkin @mhevery Review?

Closes #6907

@kara kara added the state: WIP label Feb 5, 2016
@vsavkin vsavkin self-assigned this Feb 5, 2016
@kara kara added action: review The PR is still awaiting reviews from at least one requested reviewer and removed state: WIP labels Feb 5, 2016
@kara kara added action: merge The PR is ready for merge by the caretaker state: WIP and removed action: review The PR is still awaiting reviews from at least one requested reviewer action: merge The PR is ready for merge by the caretaker labels Feb 5, 2016
@mhevery mhevery assigned kara and unassigned vsavkin Feb 5, 2016
@mhevery
Copy link
Contributor

mhevery commented Feb 5, 2016

Reviewed with Kara in person, will keep track of identity changes as a separate list.

@kara kara force-pushed the trackbyfix branch 2 times, most recently from 1200d89 to e4f5203 Compare February 6, 2016 00:33
@kara kara added action: review The PR is still awaiting reviews from at least one requested reviewer and removed state: WIP labels Feb 6, 2016
@mhevery
Copy link
Contributor

mhevery commented Feb 6, 2016

Very nice! LGTM

@mhevery mhevery added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Feb 6, 2016
@kara kara mentioned this pull request Feb 7, 2016
Closed
@jeffbcross
Copy link
Contributor

Assigning to @IgorMinar for merge

@jeffbcross jeffbcross assigned IgorMinar and unassigned kara Feb 8, 2016
@mary-poppins
Copy link

Merging PR #6923 on behalf of @btford to branch presubmit-btford-pr-6923.

@mhevery mhevery closed this in 0f10624 Feb 9, 2016
@btford
Copy link
Contributor

btford commented Feb 9, 2016

👏 good work everyone

@cexbrayat
Copy link
Member

I assume this fixes #6907 ?

@cexbrayat cexbrayat mentioned this pull request Feb 10, 2016
Closed
@kara kara deleted the trackbyfix branch October 13, 2018 01:08
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@IgorMinar IgorMinar

Labels
action: merge The PR is ready for merge by the caretaker cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ngFor] trackBy behaviour
9 participants
@kara @mhevery @jeffbcross @mary-poppins @btford @cexbrayat @vsavkin @IgorMinar @googlebot