Skip to content

Conversation

vicb
Copy link
Contributor

@vicb vicb commented Mar 29, 2016

fix

  • What is the current behavior? (You can also link to an open issue here)

Special characters (ie "/") are not encoded for dynamic segments

  • What is the new behavior (if this is a feature change)?

Special characters (ie "/") are encoded for dynamic segments

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

No

@vicb vicb added comp: router action: review The PR is still awaiting reviews from at least one requested reviewer labels Mar 29, 2016
@btford
Copy link
Contributor

btford commented Mar 29, 2016

LGTM

@vicb vicb added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Mar 29, 2016
@vicb
Copy link
Contributor Author

vicb commented Mar 29, 2016

Travis is red due to SauceLabs flakiness (not related to this PR)

@mary-poppins
Copy link

Merging PR #7804 on behalf of @kara to branch presubmit-kara-pr-7804.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants