Skip to content

Pure fn #8198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Pure fn #8198

wants to merge 3 commits into from

Conversation

tbosch
Copy link
Contributor

@tbosch tbosch commented Apr 22, 2016 •
edited
Loading

Gtihub only

tbosch
tbosch reviewed Apr 22, 2016
View reviewed changes
modules/angular2/src/compiler/output/output_interpreter.ts
@@ -187,6 +187,9 @@ class StatementInterpreter implements o.StatementVisitor, o.ExpressionVisitor {
case o.BuiltinMethod.SubscribeObservable:
result = ObservableWrapper.subscribe(receiver, args[0]);
break;
case o.BuiltinMethod.bind:
result = receiver;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not right!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@tbosch tbosch added pr_state: LGTM action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Apr 23, 2016
@tbosch
Copy link
Contributor Author

tbosch commented Apr 23, 2016

Reviewed in person with @mhevery

@tbosch tbosch force-pushed the pure_fn branch 2 times, most recently from 5d5aa93 to bf38ba7 Compare April 23, 2016 03:11
@tbosch tbosch removed the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Apr 23, 2016
@naomiblack naomiblack added action: merge The PR is ready for merge by the caretaker and removed action: merge The PR is ready for merge by the caretaker labels Apr 24, 2016
tbosch added 2 commits April 25, 2016 09:04
@tbosch
fix(compiler): properly implement pure pipes and change pipe syntax
152a117 
Pure pipes as well as arrays and maps are
implemented via proxy functions. This is
faster than the previous implementation
and also generates less code.

BREAKING CHANGE:
- pipes now take a variable number of arguments, and not an array that contains all arguments.
@tbosch
fix(compiler): use DI order for change detection order.
bd0a058
@tbosch tbosch added the action: merge The PR is ready for merge by the caretaker label Apr 25, 2016
@tbosch tbosch closed this in 67d05eb Apr 25, 2016
@tbosch tbosch deleted the pure_fn branch April 25, 2016 22:00
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tbosch @naomiblack @googlebot