fix(testing): reintroduce and deprecate setBaseTestProviders #9905
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliemr
added
the
area: testing
|
Note that I've tested this locally by changing the setup in |
juliemr
added
action: review
|
This is pending more changes to |
|
My changes are in master. |
tbosch
added
pr_state: LGTM
action: cleanup
juliemr
force-pushed
the
revive-setbasetestproviders
branch
2 times, most recently
from
5305214 to
9c21513
Compare
This change reverts the removal of setBaseTestProviders that was introduced in 8d746e3. Instead, setBaseTestProviders and the providers provided from `@angular/platform-browser-dynamic/testing` and `@angular/server/testing` will still work for the next release, but are deprecated. See 8d746e3 for how to upgrade.
juliemr
force-pushed
the
revive-setbasetestproviders
branch
from
9c21513 to
89e2a68
Compare
juliemr
removed
the
action: cleanup
|
@vikerman could you please sanity check the rebase? |
|
LGTM |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change reverts the removal of setBaseTestProviders that was
introduced in 8d746e3.
Instead, setBaseTestProviders and the providers provided from
@angular/platform-browser-dynamic/testingand@angular/server/testingwill still work for the next release, but are deprecated.
See 8d746e3 for how to upgrade.