feat(url_resolver): Allow a developer to customize their package prefix #3794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TedSander
added
the
action: review
mhevery
added
pr_state: LGTM
action: merge
|
Merging PR #3794 on behalf of @mhevery to branch presubmit-mhevery-pr-3794. |
mary-poppins
removed
the
action: merge
Allow a developer to specify a package prefix where the 'package:' dart urls will be resolved. By default this will be '/packages' keeping the current behavior, but allows for flexibility of different environments where a developer may not control their directory structure.
mary-poppins
removed
the
action: merge
|
User @TedSander does not have PR merging privileges. |
|
@mhevery The merge didn't seem successful on this PR. I rebased the CL and reran the travis checks and they seem to be fine. Can you re-run it through the merge queue? I don't have approval for that. |
|
Merging PR #3794 on behalf of @mhevery to branch presubmit-mhevery-pr-3794. |
mary-poppins
removed
the
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow a developer to specify a package prefix where the 'package:' dart urls
will be resolved. By default this will be '/packages' keeping the current
behavior, but allows for flexibility of different environments where a
developer may not control their directory structure.