fix(language-service): [Ivy] create compiler only when program changes #39231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyliau
added
area: language-service
kyliau
added
target: major
kyliau
force-pushed
the
ivy-ls-next-program
branch
from
84fe55a
to
d76750d
Compare
atscott
approved these changes
Oct 13, 2020
| }); | ||
|
|
||
| function getLastKnownProgram(ngLS: LanguageService): ts.Program { | ||
| const program = ngLS['compilerFactory']['lastKnownProgram']; |
There was a problem hiding this comment.
If it's needed for testing, maybe we should mark compilerFactory with /** @internal */ instead of accessing the private property?
There was a problem hiding this comment.
I think marking it as @internal only affects the .d.ts emit, and it's actually discouraged (they removed it from TS documentation). Is this commonly used in other Angular packages?
kyliau
force-pushed
the
ivy-ls-next-program
branch
from
d76750d
to
7c4f799
Compare
ayazhafiz
approved these changes
Oct 13, 2020
This commit fixes a bug in which a new Ivy Compiler is created every time language service receives a new request. This is not needed if the `ts.Program` has not changed. A new class `CompilerFactory` is created to manage Compiler lifecycle and keep track of template changes so that it knows when to override them. With this change, we no longer need the method `getModifiedResourceFile()` on the adapter. Instead, we call `overrideComponentTemplate` on the template type checker. This commit also changes the incremental build strategy from `PatchedIncrementalBuildStrategy` to `TrackedIncrementalBuildStrategy`.
kyliau
force-pushed
the
ivy-ls-next-program
branch
from
7c4f799
to
3c56cdd
Compare
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes a bug in which a new Ivy Compiler is created every time
language service receives a new request. This is not needed if the
ts.Programhas not changed.A new class
CompilerFactoryis created to manage Compiler lifecycle andkeep track of template changes so that it knows when to override them.
With this change, we no longer need the method
getModifiedResourceFile()on the adapter. Instead, we call
overrideComponentTemplateon thetemplate type checker.
This commit also changes the incremental build strategy from
PatchedIncrementalBuildStrategytoTrackedIncrementalBuildStrategy.PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information