Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(core): Add event delegation library to queue up events and… #55121

Closed
wants to merge 1 commit into from
Closed

feat(core): Add event delegation library to queue up events and… #55121

wants to merge 1 commit into from

Conversation

iteriani
Copy link
Contributor

… replay them when the application is ready

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • [ X] Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

n/a

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • [ X] No

Other information

@pullapprove pullapprove bot requested a review from atscott March 29, 2024 16:54
@angular-robot angular-robot bot added the detected: feature PR contains a feature commit label Mar 29, 2024
@jessicajaniuk jessicajaniuk added action: review The PR is still awaiting reviews from at least one requested reviewer area: core Issues related to the framework runtime target: major This PR is targeted for the next major release labels Mar 29, 2024
@ngbot ngbot bot modified the milestone: Backlog Mar 29, 2024
@jessicajaniuk jessicajaniuk requested review from AndrewKushnir and jessicajaniuk and removed request for atscott March 29, 2024 16:56
@iteriani iteriani changed the title feat(primitives): Add event delegation library to queue up events and… feat(core): Add event delegation library to queue up events and… Mar 29, 2024
@iteriani
feat(core): Add event delegation library to queue up events and repla…
9be0f98 
…y them when the application is ready

This adds the JSAction library from the Wiz framework to core/primitives.
jessicajaniuk
jessicajaniuk approved these changes Apr 1, 2024
View reviewed changes
Copy link
Contributor

@jessicajaniuk jessicajaniuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's likely going to be a lot of follow ups, but for now let's get this merged.

AndrewKushnir
AndrewKushnir approved these changes Apr 1, 2024
View reviewed changes
Copy link
Contributor

@AndrewKushnir AndrewKushnir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@jessicajaniuk jessicajaniuk added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Apr 1, 2024
@jessicajaniuk
Copy link
Contributor

This PR was merged into the repository by commit 666d646.

ilirbeqirii pushed a commit to ilirbeqirii/angular that referenced this pull request Apr 6, 2024
@iteriani @ilirbeqirii
feat(core): Add event delegation library to queue up events and repla…
19ee211 
…y them when the application is ready (angular#55121)

This adds the JSAction library from the Wiz framework to core/primitives.

PR Close angular#55121
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators May 3, 2024
@pullapprove pullapprove bot added the requires: TGP This PR requires a passing TGP before merging is allowed label May 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@AndrewKushnir AndrewKushnir AndrewKushnir approved these changes

@jessicajaniuk jessicajaniuk jessicajaniuk approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime detected: feature PR contains a feature commit requires: TGP This PR requires a passing TGP before merging is allowed target: major This PR is targeted for the next major release
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.
3 participants
@iteriani @jessicajaniuk @AndrewKushnir