Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): Do not migrate HttpClientModule imports on components. #56067

Closed
wants to merge 1 commit into from
Closed

fix(core): Do not migrate HttpClientModule imports on components. #56067

wants to merge 1 commit into from

Conversation

JeanMeche
Copy link
Member

@JeanMeche JeanMeche commented May 24, 2024 •
edited
Loading

provideHttpClient() returns a EnvironmentProvider which is not compatible with component providers.
Also adding a // TODO to warn about HttpClientModule not being recommended in component imports.

@JeanMeche JeanMeche force-pushed the core/http-migration-fix branch 3 times, most recently from d6bdc62 to d0848fe Compare May 24, 2024 16:44
@JeanMeche JeanMeche marked this pull request as ready for review May 24, 2024 16:44
@pullapprove pullapprove bot requested a review from dylhunn May 24, 2024 16:45
@pkozlowski-opensource pkozlowski-opensource added the area: migrations Issues related to `ng update` migrations label May 27, 2024
@ngbot ngbot bot added this to the Backlog milestone May 27, 2024
@JeanMeche JeanMeche added the action: review The PR is still awaiting reviews from at least one requested reviewer label May 28, 2024
@AndrewKushnir AndrewKushnir added target: patch This PR is targeted for the next patch release action: presubmit The PR is in need of a google3 presubmit labels May 29, 2024
@AndrewKushnir
Copy link
Contributor

Presubmit.

AndrewKushnir
AndrewKushnir approved these changes May 29, 2024
View reviewed changes
Copy link
Contributor

@AndrewKushnir AndrewKushnir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one comment to improve the TODO message.

packages/core/schematics/migrations/http-providers/utils.ts Outdated Show resolved Hide resolved
@AndrewKushnir AndrewKushnir requested review from crisbeto and removed request for dylhunn May 29, 2024 01:51
@JeanMeche
fix(core): Do not migrate HttpClientModule imports on components.
f4c030b 
`provideHttpClient()` returns a `EnvironmentProvider` which is not compatible with component providers.
@AndrewKushnir AndrewKushnir removed the action: review The PR is still awaiting reviews from at least one requested reviewer label May 29, 2024
@AndrewKushnir AndrewKushnir added action: merge The PR is ready for merge by the caretaker merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note and removed action: presubmit The PR is in need of a google3 presubmit merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note labels May 29, 2024
thePunderWoman pushed a commit that referenced this pull request May 30, 2024
@JeanMeche @thePunderWoman
fix(core): Do not migrate HttpClientModule imports on components. (#…
78cf9bf 
…56067)

`provideHttpClient()` returns a `EnvironmentProvider` which is not compatible with component providers.

PR Close #56067
@thePunderWoman
Copy link
Contributor

This PR was merged into the repository by commit 8d75627.

@ambrose40 ambrose40 mentioned this pull request Jun 27, 2024
Open
@Rosenstein Rosenstein mentioned this pull request Jun 28, 2024
Merged
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jun 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@crisbeto crisbeto crisbeto approved these changes

@AndrewKushnir AndrewKushnir AndrewKushnir approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: migrations Issues related to `ng update` migrations target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.
5 participants
@JeanMeche @AndrewKushnir @thePunderWoman @crisbeto @pkozlowski-opensource