Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(auth): removed the shareReplay from auth and addressed Zone.js issues #2682

Merged
merged 1 commit into from Nov 24, 2020
Merged

fix(auth): removed the shareReplay from auth and addressed Zone.js issues #2682

merged 1 commit into from Nov 24, 2020

Conversation

jamesdaniels
Copy link
Member

@jamesdaniels jamesdaniels commented Nov 24, 2020 •
edited

I added a shareReplay as a temporary work around to Zone.js issues in Firebase v8 with auth, I did not intent to ship this. I've since found work-arounds.

  • Only keepUnstableUntilFirst on redirectResult, shareReplay it
  • Remove shareReplay which causes issues when loading/checking auth lazily
  • Move guards over to .user so token changes will be evaluated
  • Upgrade the node modules in sample

Addresses #2681

@jamesdaniels jamesdaniels merged commit 059547b into master Nov 24, 2020
@jamesdaniels jamesdaniels deleted the auth_guard_early branch November 24, 2020 03:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jamesdaniels @googlebot