New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(storage): unsubscribing from the upload progress will not cancel … #2688

Merged

jamesdaniels merged 1 commit into master from fix_upload_cancelation

Nov 24, 2020

Member

jamesdaniels commented Nov 24, 2020

unsubscribing from upload progress shouldn't cancel the upload, that was undefined behavior IMO
shareReplay the upload, so one could pick back up (say if they had upload progress | async on a view somewhere)

Closes #2685


          fix(storage): unsubscribing from the upload progress will not cancel …

d2250c9

…and added replay

googlebot added the cla: yes label

jamesdaniels merged commit d845cdd into master

jamesdaniels deleted the fix_upload_cancelation branch

November 24, 2020 18:45

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment