Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Schematics, schematics, schematics! #2836

Merged
merged 33 commits into from
Sep 14, 2021
Merged

Schematics, schematics, schematics! #2836

merged 33 commits into from
Sep 14, 2021

Conversation

jamesdaniels
Copy link
Member

@jamesdaniels jamesdaniels commented May 18, 2021

TODO

  • Allow non-standard browser/server dist paths
  • Allow override of functions/run dist path
  • Check for gcloud cli
  • Get tests green and cover
  • Can we query Google's repository to validate Node.js version rather than docker hub?
  • tidy/dry up
  • write the environment config
  • allow addition of modules to the app.module
  • better handle conflicts / merging of config
  • add .firebase/ and logs to .gitignore
  • allow basic configuration of the Cloud Run instance
  • default to all the prior defaults, e.g, ng deploy will succeed on an 7.0.4 app

@jamesdaniels jamesdaniels changed the title Cleaning up the peer deps Do more with schematics! May 20, 2021
@jamesdaniels jamesdaniels added this to the 6.2 milestone May 20, 2021
@jamesdaniels jamesdaniels changed the title Do more with schematics! Schematics, schematics, schematics! May 26, 2021
@rgant

This comment has been minimized.

@jamesdaniels jamesdaniels modified the milestones: 6.2, 7.1 Aug 25, 2021
@google-cla google-cla bot added cla: no and removed cla: yes labels Sep 14, 2021
@googlebot
Copy link

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@googlebot
Copy link

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

1 similar comment
@google-cla
Copy link

google-cla bot commented Sep 14, 2021

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added cla: no and removed cla: yes labels Sep 14, 2021
@googlebot
Copy link

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

1 similar comment
@google-cla
Copy link

google-cla bot commented Sep 14, 2021

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@google-cla
Copy link

google-cla bot commented Sep 14, 2021

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

1 similar comment
@googlebot
Copy link

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

@jamesdaniels jamesdaniels merged commit 72d3c2e into master Sep 14, 2021
@jamesdaniels jamesdaniels deleted the peerFixes branch September 14, 2021 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants