Skip to content

Firestore document set method missing options parameter #1332

@moneal

Description

@moneal

Version info

Angular: *

Firebase: *

AngularFire: 5.0.0-rc3

How to reproduce these conditions

Calling set on a document reference that does not exist causes a error. The set options parameter is missing from the set method in angularfire2. With options is possible to set values on a document that doesn't yet exist.

Expected behavior

Allow the same parameters as DocumentReference's set method in firebase JS API.

Actual behavior

Browser when entity does not exist: ERROR Error: Uncaught (in promise): FirebaseError: [code=not-found]: no entity to update
Typescript Lint: [ts] Expected 1 arguments, but got 2.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions