Skip to content
This repository was archived by the owner on Feb 9, 2020. It is now read-only.

Conversation

oliversalzburg
Copy link

This change implements annotation through ng-annotate, thus reducing the risk of missing any annotations now or in the future.

Adding the annotations to angularjs-batarang itself does not fully fix the issue, as dependencies of this project also have missing annotations. For example here: https://github.com/angular/angular-hint-controllers/blob/master/hint-controllers.js#L19

Closes #136
Fixes #119
Fixes #138

This change implements annotation through ng-annotate, thus reducing the risk of missing any annotations now or in the future.
Closes #136
Fixes #119
Fixes #138
@btford
Copy link
Contributor

btford commented Dec 10, 2014

The line you linked to is in fact annotated.

@oliversalzburg
Copy link
Author

@btford It is now: https://github.com/angular/angular-hint-controllers/commit/13ea4b0c5bbd5f8cde991ad89cc2a32c596d4917 (I foolishly linked directly to master).

My point being, the code in the dependencies changes and DI annotation can be an issue. Having it automatically inserted during the build process seems very beneficial to me.
One the one hand you have your source, which no longer is required to include DI annotation and on the other you have output which reliably includes all necessary annotation.

@SomeKittens SomeKittens closed this May 9, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

compatibility with angular 1.3 ngStrictDi Injected functions are not annotated causing angular not to load when the ng-strict-di directive is present
3 participants