This repository has been archived by the owner on Feb 26, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 26
does not work when using with new traceur-runtime.js
#21
Comments
Thanks, will look into this. |
jeffbcross
added a commit
to jeffbcross/benchpress
that referenced
this issue
Dec 17, 2014
…h consumers Closes angular#21
This was referenced Dec 17, 2014
Merged
Getting rid of traceur-runtime would be nice since it's more bytes, and since it's adding junk to the global object. Perhaps it's worth building a simplified DI for benchpress. The auto-running context (ie benchmark runs in its own window or iframe) doesn't automatically solve the problem, because there still needs to be a runner present with the benchmark, to actually execute the code, time the tests, collect results, dispatch result events, etc. I opened #24 with a proposal to properly address this issue, without giving up on DI altogether. In the meantime, I'll merge a fix that renames the |
Published to npm @0.2.2 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Benchpress includes
di.js
which includestraceur-runtime.js
in version 0.0.25. However, Angular2 is using traceur 0.0.74, and the two traceur-runtime.js are not compatible either way (code generated for the on does not run with the other).I think we should either get rid of
traceur-runtime
withinbp.js
, or implement the frame approach, i.e. there won't be abp.js
in the application under test, only in the parent frame.The text was updated successfully, but these errors were encountered: