Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: DLLs for win32 bin #49

Closed
wants to merge 1 commit into from
Closed

feat: DLLs for win32 bin #49

wants to merge 1 commit into from

Conversation

FabienDehopre
Copy link

I added both msvcp140.dll and vcruntime140.dll in the win32 bin folder.
This is related to #48

@mprobst
Copy link
Contributor

mprobst commented Oct 12, 2017

I don't think we can just ship these, can we? What's the license on those binaries?

@FabienDehopre
Copy link
Author

I don't know is the license for those DLLs but they can both be downloaded for free either directly or via the VS 2015 C++ Redist Package (https://www.microsoft.com/en-us/download/details.aspx?id=48145)

Here is what I found about redistributing those DLLs on the Microsoft website: https://docs.microsoft.com/en-us/cpp/ide/redistributing-visual-cpp-files

@mprobst
Copy link
Contributor

mprobst commented Oct 16, 2017

Let's see if we can make #50 work in favour of this, I'd feel a lot more comfortable with a statically linked binary than with redistributing other dlls. Plus, it's conceptually the right fix :-)

@mprobst mprobst closed this Oct 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants