Update to ES6, expose getNativeBinary #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexeagle
approved these changes
Mar 29, 2018
| var spawn = require('child_process').spawn; | ||
| var glob = require('glob'); | ||
| var async = require('async'); | ||
| const fs = require('fs'); |
There was a problem hiding this comment.
you changed this file to no longer be executable, is that intended?
|
No. I am not sure how I did that. I'll update.
…On Wed, Mar 28, 2018, 18:12 Alex Eagle ***@***.***> wrote:
***@***.**** approved this pull request.
------------------------------
In index.js
<#55 (comment)>:
> @@ -1,32 +1,36 @@
#!/usr/bin/env node
'use strict';
-var fs = require('fs');
-var os = require('os');
-var path = require('path');
-var resolve = require('resolve').sync;
-var spawn = require('child_process').spawn;
-var glob = require('glob');
-var async = require('async');
+const fs = require('fs');
you changed this file to no longer be executable, is that intended?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#55 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAPL8meohP8Cr2fbjJPBt7-lQmdyyyvjks5tjDTggaJpZM4S_jDH>
.
|
- use ES6 sugar, - split utility functions, - format the code with clang-fromat!
Returns the platform specific path to the clang-format executable
|
@vicb can you change the commit description to include why we expose the native binary? sounds like that should be an implementation detail. |
|
Rationale is I was trying to write a clang-format plugin for precise-commits and needed something synchronous. Up for debate. |
mprobst
approved these changes
Apr 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@alexeagle