Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add binary for linux ia32 #70

Closed

Conversation

RaisinTen
Copy link
Contributor

@RaisinTen RaisinTen commented Mar 8, 2021

Based on the changes upto:
llvm/llvm-project@632668c

Build script:

git clone https://github.com/llvm/llvm-project.git
cd llvm-project
git reset --hard 632668c1c0e7dcf97154d2e377491cdc8cb6963c
mkdir build
cd build
cmake -G Ninja -DCMAKE_BUILD_TYPE=MinSizeRel -DLLVM_BUILD_STATIC=true -DLLVM_ENABLE_PROJECTS=clang -DCMAKE_GENERATOR_PLATFORM=x86 ../llvm
ninja clang-format
strip bin/clang-format

@mprobst
Copy link
Contributor

mprobst commented Apr 20, 2021

Sorry for the long wait, I was on a prolonged leave.

Can you share what command / configuration you used to build these? I think I'll need to repro that myself; I cannot accept arbitrary binaries into the project that I didn't build, for security reasons (I hope you can understand that).

Based on the changes upto:
llvm/llvm-project@632668c

Build script:

```console
git clone --depth=1 https://github.com/llvm/llvm-project.git
cd llvm-project
mkdir build
cd build
cmake -G Ninja -DCMAKE_BUILD_TYPE=MinSizeRel -DLLVM_BUILD_STATIC=true -DLLVM_ENABLE_PROJECTS=clang ../llvm
ninja clang-format
strip bin/clang-format
```
@RaisinTen RaisinTen force-pushed the feat/add-binary-for-linux-ia32 branch from 3685b8c to e8f5090 Compare May 15, 2021 15:17
@RaisinTen
Copy link
Contributor Author

@mprobst Sorry, I was busy working on my other PRs, so I couldn't really get back to you. I noticed that the way I built the binary earlier was not the right way as it was 94 MB! So, I have rebuilt it using the info given in the readme with some slight modifications as the default script did not work. I have updated the PR info with the script I used. I'll shoot a PR to update the same in the readme.

@RaisinTen
Copy link
Contributor Author

PR to fix the build script: #71

@RaisinTen
Copy link
Contributor Author

@mprobst gentle reminder, in case you forgot about reviewing this PR and the one I linked to above :)

@RaisinTen
Copy link
Contributor Author

@mprobst bump

@mprobst
Copy link
Contributor

mprobst commented Oct 25, 2021

Sorry, the bottleneck is that I do now know how to produce an i386 binary on an x64 machine (i.e. cross compile in llvm), and as I said above, I cannot just accept a compiled binary from a third party, for security reasons (not that I have reasons not to trust you, but general policy is to only accept changes that can be reviewed, and the binary dump here cannot be reviewed).

Do you have a suggestion for a cross compilation setup here?

@RaisinTen
Copy link
Contributor Author

RaisinTen commented Oct 30, 2021

@mprobst I have updated the script in the PR description to build a 32-bit binary by adding the -DCMAKE_GENERATOR_PLATFORM=x86 option to cmake. You could try this locally and then compare the file hashes. I can't test this myself because I don't use a 32-bit Linux anymore.

@mprobst
Copy link
Contributor

mprobst commented Nov 8, 2021 via email

@RaisinTen
Copy link
Contributor Author

Eh, probably not. I'm okay with closing this at this point in time! :)

@RaisinTen RaisinTen closed this Nov 11, 2021
@RaisinTen RaisinTen deleted the feat/add-binary-for-linux-ia32 branch November 11, 2021 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants