-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add binary for linux ia32 #70
Conversation
Sorry for the long wait, I was on a prolonged leave. Can you share what command / configuration you used to build these? I think I'll need to repro that myself; I cannot accept arbitrary binaries into the project that I didn't build, for security reasons (I hope you can understand that). |
Based on the changes upto: llvm/llvm-project@632668c Build script: ```console git clone --depth=1 https://github.com/llvm/llvm-project.git cd llvm-project mkdir build cd build cmake -G Ninja -DCMAKE_BUILD_TYPE=MinSizeRel -DLLVM_BUILD_STATIC=true -DLLVM_ENABLE_PROJECTS=clang ../llvm ninja clang-format strip bin/clang-format ```
3685b8c
to
e8f5090
Compare
@mprobst Sorry, I was busy working on my other PRs, so I couldn't really get back to you. I noticed that the way I built the binary earlier was not the right way as it was 94 MB! So, I have rebuilt it using the info given in the readme with some slight modifications as the default script did not work. I have updated the PR info with the script I used. I'll shoot a PR to update the same in the readme. |
PR to fix the build script: #71 |
@mprobst gentle reminder, in case you forgot about reviewing this PR and the one I linked to above :) |
@mprobst bump |
Sorry, the bottleneck is that I do now know how to produce an i386 binary on an x64 machine (i.e. cross compile in llvm), and as I said above, I cannot just accept a compiled binary from a third party, for security reasons (not that I have reasons not to trust you, but general policy is to only accept changes that can be reviewed, and the binary dump here cannot be reviewed). Do you have a suggestion for a cross compilation setup here? |
@mprobst I have updated the script in the PR description to build a 32-bit binary by adding the |
If you don't use 32bit linux, nor do I - do we believe this really
helps anyone at this point?
|
Eh, probably not. I'm okay with closing this at this point in time! :) |
Based on the changes upto:
llvm/llvm-project@632668c
Build script: