This repository has been archived by the owner on Feb 26, 2024. It is now read-only.
add closure nightly builds to Travis #521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rkirov
commented
Jun 12, 2017
.travis.yml
Outdated
| matrix: | ||
| fast_finish: true | ||
| allow_failures: | ||
| - env: "CI_MODE=Nightly" |
There was a problem hiding this comment.
copied this from angular -
https://github.com/angular/angular/blob/master/.travis.yml#L56
For now nightly build failures are not blocking submission. Also upgrade released version to 0527.
dpurp
approved these changes
Jun 12, 2017
alexeagle
reviewed
Jun 12, 2017
| @@ -19,7 +19,7 @@ public void testDuplicateSymbol() { | |||
| // Useful | |||
| assertThatProgram("/** @type {number} */ var x = 1;", "/** @type {number} */ var x = 2;") | |||
| .diagnosticStream() | |||
| .containsMatch("ERROR.*Variable x first declared in"); | |||
| .containsMatch("ERROR.*Variable x declared more than once"); | |||
There was a problem hiding this comment.
this test passes on both released and snapshot compiler versions?
There was a problem hiding this comment.
snapshot is broken for other reasons. Can't change it to work for both (golden tests).
alexeagle
approved these changes
Jun 12, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For now nightly build failures are not blocking submission.
Also upgrade released version to 0527.