Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(select): don't emit change event multiple times when a reset option is selected twice in a row #10859

Closed
wants to merge 1 commit into from
Closed

fix(select): don't emit change event multiple times when a reset option is selected twice in a row #10859

wants to merge 1 commit into from

Conversation

crisbeto
Copy link
Member

Fixes the select's change events being fired when a reset option is selected twice in a row.

Fixes #10675.

@crisbeto crisbeto requested a review from kara as a code owner April 14, 2018 13:03
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Apr 14, 2018
jelbourn
jelbourn approved these changes Apr 26, 2018
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release and removed pr: needs review labels Apr 26, 2018
@ngbot
Copy link

ngbot bot commented Apr 26, 2018

I see that you just added the pr: merge ready label, but the following checks are still failing:
    failure status "continuous-integration/travis-ci/pr" is failing
    pending 1 pending code review

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@ngbot
Copy link

ngbot bot commented Jun 20, 2018

Hi @crisbeto! This PR has merge conflicts due to recent upstream merges.
Please help to unblock it by resolving these conflicts. Thanks!

@crisbeto crisbeto force-pushed the 10675/select-change-event-reset-option branch from 5d71da1 to 53358ba Compare June 20, 2018 21:04
@ngbot
Copy link

ngbot bot commented Jun 26, 2018

Hi @crisbeto! This PR has merge conflicts due to recent upstream merges.
Please help to unblock it by resolving these conflicts. Thanks!

@josephperrott josephperrott added pr: needs rebase and removed action: merge The PR is ready for merge by the caretaker labels Jun 26, 2018
@crisbeto crisbeto force-pushed the 10675/select-change-event-reset-option branch from 53358ba to efe4c46 Compare June 28, 2018 05:49
@crisbeto crisbeto added action: merge The PR is ready for merge by the caretaker and removed pr: needs rebase labels Jun 28, 2018
@jelbourn
Copy link
Member

@crisbeto github shows this PR as having no conflicts, but our presubmit script thinks it does. Could you rebase it?

@crisbeto
fix(select): don't emit change event multiple times when a reset opti…
0e8560b 
…on is selected twice in a row

Fixes the select's change events being fired when a reset option is selected twice in a row.

Fixes angular#10675.
@crisbeto
Copy link
Member Author

Done.

@crisbeto crisbeto force-pushed the 10675/select-change-event-reset-option branch from efe4c46 to 0e8560b Compare August 26, 2018 16:51
crisbeto added a commit to crisbeto/material2 that referenced this pull request Oct 13, 2018
@crisbeto
fix(select): emitting change even twice for reset values
5d1bb3c 
Fixes `mat-select` emitting its change event twice when a reset value is selected, as well as when it's selected twice in a row. This PR covers angular#10859 which would've introduced another issue.

Fixes angular#10675.
Fixes angular#13579.
@crisbeto crisbeto mentioned this pull request Oct 13, 2018
Merged
@crisbeto
Copy link
Member Author

Closing since this PR would've ended up introducing an issue where the reset option can get marked as selected. The issue it was fixing originally will be covered by #13598.

@crisbeto crisbeto closed this Oct 13, 2018
crisbeto added a commit to crisbeto/material2 that referenced this pull request Oct 13, 2018
@crisbeto
fix(select): emitting change event twice for reset values
f3120bf 
Fixes `mat-select` emitting its change event twice when a reset value is selected, as well as when it's selected twice in a row. This PR covers angular#10859 which would've introduced another issue.

Fixes angular#10675.
Fixes angular#13579.
vivian-hu-zz pushed a commit that referenced this pull request Nov 6, 2018
@crisbeto
fix(select): emitting change event twice for reset values
5289010 
Fixes `mat-select` emitting its change event twice when a reset value is selected, as well as when it's selected twice in a row. This PR covers #10859 which would've introduced another issue.

Fixes #10675.
Fixes #13579.
crisbeto added a commit to crisbeto/material2 that referenced this pull request Dec 13, 2018
@crisbeto
fix(select): emitting change event twice for reset values
55dbbf4 
Fixes `mat-select` emitting its change event twice when a reset value is selected, as well as when it's selected twice in a row. This PR covers angular#10859 which would've introduced another issue.

Fixes angular#10675.
Fixes angular#13579.
crisbeto added a commit to crisbeto/material2 that referenced this pull request Dec 22, 2018
@crisbeto
fix(select): emitting change event twice for reset values
1dad2a8 
Fixes `mat-select` emitting its change event twice when a reset value is selected, as well as when it's selected twice in a row. This PR covers angular#10859 which would've introduced another issue.

Fixes angular#10675.
Fixes angular#13579.
crisbeto added a commit to crisbeto/material2 that referenced this pull request Jun 19, 2019
@crisbeto
fix(select): emitting change event twice for reset values
51a8079 
Fixes `mat-select` emitting its change event twice when a reset value is selected, as well as when it's selected twice in a row. This PR covers angular#10859 which would've introduced another issue.

Fixes angular#10675.
Fixes angular#13579.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

@kara kara Awaiting requested review from kara

Assignees

@jelbourn jelbourn

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Selecting reset option in mat-select
4 participants
@crisbeto @jelbourn @googlebot @josephperrott