fix(material/checkbox): model value not updated when using toggle method #11902

crisbeto · 2018-06-23T17:26:29Z

Along the same lines as #11812. The checkbox doesn't update its ControlValueAccessor value when it is toggled via the toggle method.

ngbot · 2018-06-23T18:40:27Z

I see that you just added the pr: merge ready label, but the following checks are still failing:
missing required label: "target: *"

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

ngbot · 2018-06-29T15:54:19Z

Hi @crisbeto! This PR has merge conflicts due to recent upstream merges.
Please help to unblock it by resolving these conflicts. Thanks!

tinayuangao

LGTM

ngbot · 2018-08-01T14:24:19Z

Hi @crisbeto! This PR has merge conflicts due to recent upstream merges.
Please help to unblock it by resolving these conflicts. Thanks!

gizm0bill · 2018-11-23T08:00:09Z

Are you still working on this? Merge it already!

EKashpersky · 2019-09-23T06:40:13Z

Hey guys, are there going to be any updates on the merging?

EKashpersky · 2019-09-29T09:17:34Z

@jelbourn hey there's your review is required, could you check your schedule and say when it's possible to do?
Thx in advance.

gizm0bill · 2019-09-29T12:16:13Z

Or appoint someone else to do it

…toggle method Along the same lines as angular#11902. When the value of an experimental checkbox is changed through the `toggle` method it wasn't being propagated to the `ControlValueAccessor`.

…toggle method (#17229) Along the same lines as #11902. When the value of an experimental checkbox is changed through the `toggle` method it wasn't being propagated to the `ControlValueAccessor`.

…toggle method (#17229) Along the same lines as #11902. When the value of an experimental checkbox is changed through the `toggle` method it wasn't being propagated to the `ControlValueAccessor`. (cherry picked from commit f178f20)

etonyali · 2019-11-25T17:43:07Z

It is ridiculous to take so much time to merge this. I am trying to get valueChanges for checkbox but it is not working. We are tired of hacking stuff...

Splaktar

LGTM

JoanSernaLeiton · 2021-10-19T16:15:50Z

When is it planned to merge these changes ? @Splaktar @crisbeto

Along the same lines as angular#11812. The checkbox doesn't update its `ControlValueAccessor` value when it is toggled via the `toggle` method.

…hod (#11902) Along the same lines as #11812. The checkbox doesn't update its `ControlValueAccessor` value when it is toggled via the `toggle` method. (cherry picked from commit 9371606)

This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [@angular/cdk](https://github.com/angular/components) | dependencies | patch | [`13.3.0` -> `13.3.1`](https://renovatebot.com/diffs/npm/@angular%2fcdk/13.3.0/13.3.1) | | [@angular/material](https://github.com/angular/components) | dependencies | patch | [`13.3.0` -> `13.3.1`](https://renovatebot.com/diffs/npm/@angular%2fmaterial/13.3.0/13.3.1) | --- ### Release Notes <details> <summary>angular/components</summary> ### [`v13.3.1`](https://github.com/angular/components/blob/HEAD/CHANGELOG.md#1331-pearl-necklace-2022-03-23) [Compare Source](angular/components@13.3.0...13.3.1) ##### cdk | Commit | Type | Description | | -- | -- | -- | | [cf24b704d](angular/components@cf24b70) | fix | **schematics:** mark `ng-add` schematics as hidden | | [4a4ebe7df](angular/components@4a4ebe7) | perf | **scrolling:** do not run change detection if there are no `viewChange` listeners ([#23987](angular/components#23987)) | ##### material | Commit | Type | Description | | -- | -- | -- | | [0897f49d7](angular/components@0897f49) | fix | **autocomplete:** re-enter the Angular zone when the `NgZone.onStable` emits ([#24569](angular/components#24569)) | | [51ddecbbb](angular/components@51ddecb) | fix | **checkbox:** model value not updated when using toggle method ([#11902](angular/components#11902)) | | [174871713](angular/components@1748717) | fix | **input:** resolve memory leak on iOS ([#24599](angular/components#24599)) | | [eed36b3ba](angular/components@eed36b3) | fix | **schematics:** mark `ng-add` schematics as hidden | | [240b238f9](angular/components@240b238) | fix | **select:** NVDA reading out table when opening select on Chrome ([#23446](angular/components#23446)) | | [e04b7aeee](angular/components@e04b7ae) | fix | **select:** value set through property not being propagated to value accessor ([#10246](angular/components#10246)) | | [5e5b296bf](angular/components@5e5b296) | perf | **icon:** remove IE workaround ([#24514](angular/components#24514)) | ##### material-experimental | Commit | Type | Description | | -- | -- | -- | | [b09c7427c](angular/components@b09c742) | fix | **mdc-chips:** replace innerText w/ textContent ([#24635](angular/components#24635)) | ##### multiple | Commit | Type | Description | | -- | -- | -- | | [0a3c7d7c4](angular/components@0a3c7d7) | fix | memory leak when forcing focus ([#24520](angular/components#24520)) | #### Special Thanks Alan Agius, Artur Androsovych, CommanderRoot, Jeremy Elbourn, Joey Perrott, Kristiyan Kostadinov, Paul Gschwendtner, Wagner Maciel and tomicarsk6  </details> --- ### Configuration 📅 **Schedule**: At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). Co-authored-by: cabr2-bot <cabr2.help@gmail.com> Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1241 Reviewed-by: Epsilon_02 <epsilon_02@noreply.codeberg.org> Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org> Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>

…hod (angular#11902) Along the same lines as angular#11812. The checkbox doesn't update its `ControlValueAccessor` value when it is toggled via the `toggle` method.

angular-automatic-lock-bot · 2022-04-21T00:04:32Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

crisbeto assigned tinayuangao Jun 23, 2018

crisbeto requested review from devversion and tinayuangao as code owners June 23, 2018 17:26

googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jun 23, 2018

devversion approved these changes Jun 23, 2018

View reviewed changes

devversion added pr: lgtm action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Jun 23, 2018

tinayuangao approved these changes Jun 29, 2018

View reviewed changes

crisbeto force-pushed the checkbox-toggle-model-value branch from ba4fe2f to 62b9ef7 Compare June 30, 2018 07:48

crisbeto mentioned this pull request Jul 25, 2018

The toggle method on mat-checkbox does not emit to valueChanges #12369

Closed

ngbot bot unassigned tinayuangao Aug 1, 2018

crisbeto force-pushed the checkbox-toggle-model-value branch from 62b9ef7 to d81826b Compare August 1, 2018 21:17

crisbeto requested review from jelbourn and josephperrott as code owners August 1, 2018 21:17

josephperrott approved these changes Aug 2, 2018

View reviewed changes

gizm0bill mentioned this pull request Nov 23, 2018

The toggle method on mat-checkbox does not emit to valueChanges #14245

Closed

crisbeto force-pushed the checkbox-toggle-model-value branch from d81826b to 166b3b1 Compare January 4, 2019 16:05

mmalerba added aaa and removed aaa labels Apr 25, 2019

andrewseguin added the P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent label May 30, 2019

crisbeto force-pushed the checkbox-toggle-model-value branch from 166b3b1 to da25796 Compare June 19, 2019 20:41

crisbeto mentioned this pull request Sep 29, 2019

fix(material-experimental/checkbox): model value not updated through toggle method #17229

Merged

Splaktar approved these changes Nov 25, 2019

View reviewed changes

mmalerba removed the lgtm label Jul 31, 2020

andrewseguin removed the cla: yes PR author has agreed to Google's Contributor License Agreement label Dec 29, 2021

crisbeto changed the title ~~fix(checkbox): model value not updated when using toggle method~~ fix(material/checkbox): model value not updated when using toggle method Mar 20, 2022

fix(material/checkbox): model value not updated when using toggle method

2be03a3

Along the same lines as angular#11812. The checkbox doesn't update its `ControlValueAccessor` value when it is toggled via the `toggle` method.

crisbeto force-pushed the checkbox-toggle-model-value branch from da25796 to 2be03a3 Compare March 20, 2022 08:28

crisbeto requested a review from andrewseguin as a code owner March 20, 2022 08:28

crisbeto merged commit 9371606 into angular:master Mar 21, 2022

sync-by-unito bot mentioned this pull request Mar 25, 2022

build(deps): bump @angular/cdk from 12.2.4 to 13.3.1 numbersprotocol/capture-cam#1421

Closed

sync-by-unito bot mentioned this pull request Mar 31, 2022

build(deps): bump @angular/cdk from 12.2.4 to 13.3.2 numbersprotocol/capture-cam#1463

Closed

angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 21, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(material/checkbox): model value not updated when using toggle method #11902

fix(material/checkbox): model value not updated when using toggle method #11902

Uh oh!

crisbeto commented Jun 23, 2018

Uh oh!

ngbot bot commented Jun 23, 2018

Uh oh!

ngbot bot commented Jun 29, 2018

Uh oh!

tinayuangao left a comment

Uh oh!

ngbot bot commented Aug 1, 2018

Uh oh!

gizm0bill commented Nov 23, 2018

Uh oh!

EKashpersky commented Sep 23, 2019

Uh oh!

EKashpersky commented Sep 29, 2019

Uh oh!

gizm0bill commented Sep 29, 2019

Uh oh!

etonyali commented Nov 25, 2019

Uh oh!

Splaktar left a comment

Uh oh!

JoanSernaLeiton commented Oct 19, 2021

Uh oh!

angular-automatic-lock-bot bot commented Apr 21, 2022

Uh oh!

Uh oh!

fix(material/checkbox): model value not updated when using toggle method #11902

fix(material/checkbox): model value not updated when using toggle method #11902

Uh oh!

Conversation

crisbeto commented Jun 23, 2018

Uh oh!

ngbot bot commented Jun 23, 2018

Uh oh!

ngbot bot commented Jun 29, 2018

Uh oh!

tinayuangao left a comment

Choose a reason for hiding this comment

Uh oh!

ngbot bot commented Aug 1, 2018

Uh oh!

gizm0bill commented Nov 23, 2018

Uh oh!

EKashpersky commented Sep 23, 2019

Uh oh!

EKashpersky commented Sep 29, 2019

Uh oh!

gizm0bill commented Sep 29, 2019

Uh oh!

etonyali commented Nov 25, 2019

Uh oh!

Splaktar left a comment

Choose a reason for hiding this comment

Uh oh!

JoanSernaLeiton commented Oct 19, 2021

Uh oh!

angular-automatic-lock-bot bot commented Apr 21, 2022

Uh oh!

Uh oh!