Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose effective tooltip position as a class on the tooltip component #15216

Closed
alirezamirian opened this issue Feb 17, 2019 · 1 comment · Fixed by #15217, cayacdev/cashbox#88, ToWipf/jasmarty#155 or CarlosPavajeau/Kaizen#251
Closed

Expose effective tooltip position as a class on the tooltip component #15216

alirezamirian opened this issue Feb 17, 2019 · 1 comment · Fixed by #15217, cayacdev/cashbox#88, ToWipf/jasmarty#155 or CarlosPavajeau/Kaizen#251
Assignees
@crisbeto
Labels
area: material/tooltip feature This issue represents a new feature or feature request rather than a bug or bug fix P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent

Comments

@alirezamirian
Copy link

Please describe the feature you would like to request.

Expose effective tooltip position as a class on the tooltip component

What is the use-case or motivation for this proposal?

This enables appearance customizations like adding triangles to all tooltips with a simple css, based on position classes.

Is there anything else we should know?

It's important to consider effective position, which is not necessarily equal to one which is passed as input.
@alirezamirian alirezamirian changed the title expose effective tooltip position as a class on the tooltip component Expose effective tooltip position as a class on the tooltip component Feb 17, 2019
@crisbeto crisbeto self-assigned this Feb 17, 2019
crisbeto added a commit to crisbeto/material2 that referenced this issue Feb 17, 2019
@crisbeto
feat(tooltip): add class to tooltip element based on the current posi…
b8ad16c 
…tion

Adds a class on the tooltip overlay element that indicates the current position of the tooltip. This allows for the tooltip to be customized to add position-based arrows or box shadows.

Fixes angular#15216.
@crisbeto crisbeto added feature This issue represents a new feature or feature request rather than a bug or bug fix has pr P4 A relatively minor issue that is not relevant to core functions labels Feb 17, 2019
@crisbeto crisbeto mentioned this issue Feb 17, 2019
Merged
crisbeto added a commit to crisbeto/material2 that referenced this issue Feb 17, 2019
@crisbeto
feat(tooltip): add class to tooltip element based on the current posi…
5556029 
…tion

Adds a class on the tooltip overlay element that indicates the current position of the tooltip. This allows for the tooltip to be customized to add position-based arrows or box shadows.

Fixes angular#15216.
crisbeto added a commit to crisbeto/material2 that referenced this issue Feb 17, 2019
@crisbeto
feat(tooltip): add class to tooltip element based on the current posi…
712fdf0 
…tion

Adds a class on the tooltip overlay element that indicates the current position of the tooltip. This allows for the tooltip to be customized to add position-based arrows or box shadows.

Fixes angular#15216.
crisbeto added a commit to crisbeto/material2 that referenced this issue Mar 16, 2019
@crisbeto
feat(tooltip): add class to tooltip element based on the current posi…
68ab64b 
…tion

Adds a class on the tooltip overlay element that indicates the current position of the tooltip. This allows for the tooltip to be customized to add position-based arrows or box shadows.

Fixes angular#15216.
crisbeto added a commit to crisbeto/material2 that referenced this issue Jun 8, 2019
@crisbeto
feat(tooltip): add class to tooltip element based on the current posi…
630925e 
…tion

Adds a class on the tooltip overlay element that indicates the current position of the tooltip. This allows for the tooltip to be customized to add position-based arrows or box shadows.

Fixes angular#15216.
crisbeto added a commit to crisbeto/material2 that referenced this issue Aug 7, 2019
@crisbeto
feat(tooltip): add class to tooltip element based on the current posi…
ece32a6 
…tion

Adds a class on the tooltip overlay element that indicates the current position of the tooltip. This allows for the tooltip to be customized to add position-based arrows or box shadows.

Fixes angular#15216.
crisbeto added a commit to crisbeto/material2 that referenced this issue Sep 14, 2019
@crisbeto
feat(tooltip): add class to tooltip element based on the current posi…
c0baf8f 
…tion

Adds a class on the tooltip overlay element that indicates the current position of the tooltip. This allows for the tooltip to be customized to add position-based arrows or box shadows.

Fixes angular#15216.
crisbeto added a commit to crisbeto/material2 that referenced this issue Jan 31, 2020
@crisbeto
feat(tooltip): add class to tooltip element based on the current posi…
40ef501 
…tion

Adds a class on the tooltip overlay element that indicates the current position of the tooltip. This allows for the tooltip to be customized to add position-based arrows or box shadows.

Fixes angular#15216.
crisbeto added a commit to crisbeto/material2 that referenced this issue Feb 10, 2020
@crisbeto
feat(tooltip): add class to tooltip element based on the current posi…
dea4ada 
…tion

Adds a class on the tooltip overlay element that indicates the current position of the tooltip. This allows for the tooltip to be customized to add position-based arrows or box shadows.

Fixes angular#15216.
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent and removed P4 A relatively minor issue that is not relevant to core functions labels Jun 3, 2020
@crisbeto crisbeto mentioned this issue Jun 3, 2020
Closed
crisbeto added a commit to crisbeto/material2 that referenced this issue Jul 16, 2020
@crisbeto
feat(tooltip): add class to tooltip element based on the current posi…
160f134 
…tion

Adds a class on the tooltip overlay element that indicates the current position of the tooltip. This allows for the tooltip to be customized to add position-based arrows or box shadows.

Fixes angular#15216.
crisbeto added a commit to crisbeto/material2 that referenced this issue Jul 26, 2020
@crisbeto
feat(tooltip): add class to tooltip element based on the current posi…
ead811b 
…tion

Adds a class on the tooltip overlay element that indicates the current position of the tooltip. This allows for the tooltip to be customized to add position-based arrows or box shadows.

Fixes angular#15216.
crisbeto added a commit to crisbeto/material2 that referenced this issue Aug 22, 2020
@crisbeto
feat(tooltip): add class to tooltip element based on the current posi…
c66f6ef 
…tion

Adds a class on the tooltip overlay element that indicates the current position of the tooltip. This allows for the tooltip to be customized to add position-based arrows or box shadows.

Fixes angular#15216.
crisbeto added a commit to crisbeto/material2 that referenced this issue Feb 9, 2021
@crisbeto
feat(material/tooltip): add class to tooltip element based on the cur…
325c4b2 
…rent position

Adds a class on the tooltip overlay element that indicates the current position of the
tooltip. This allows for the tooltip to be customized to add position-based arrows or
box shadows.

Fixes angular#15216.
mmalerba pushed a commit that referenced this issue Feb 10, 2021
@crisbeto
feat(material/tooltip): add class to tooltip element based on the cur…
1a10027 
…rent position (#15217)

Adds a class on the tooltip overlay element that indicates the current position of the
tooltip. This allows for the tooltip to be customized to add position-based arrows or
box shadows.

Fixes #15216.
This was referenced Mar 11, 2021
Closed
Merged
Merged
Merged
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Mar 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@crisbeto crisbeto

Labels
area: material/tooltip feature This issue represents a new feature or feature request rather than a bug or bug fix P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
Projects
None yet
Milestone
No milestone
3 participants
@alirezamirian @crisbeto @andrewseguin