Skip to content

fix(tabs): mark tab body as a scrollable container #16344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 9, 2021
Merged

fix(tabs): mark tab body as a scrollable container #16344

merged 1 commit into from
Feb 9, 2021

Conversation

crisbeto
Copy link
Member

Since the tab body content can be scrollable and consumers don't have access to the DOM element, we have to mark it as a CdkScrollable in order to allow for overlays inside the tabs to reposition.

Fixes #8405.

This is a resubmit of #8962 which was getting very stale.

@crisbeto
fix(tabs): mark tab body as a scrollable container
f6f474c 
Since the tab body content can be scrollable and consumers don't have access to the DOM element, we have to mark it as a CdkScrollable in order to allow for overlays inside the tabs to reposition.

Fixes angular#8405.
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release labels Jun 20, 2019
@crisbeto crisbeto requested a review from andrewseguin as a code owner June 20, 2019 19:40
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jun 20, 2019
@crisbeto crisbeto mentioned this pull request Jun 20, 2019
Closed
@andrewseguin andrewseguin added lgtm action: merge The PR is ready for merge by the caretaker labels Jun 15, 2020
@mmalerba mmalerba removed the lgtm label Jul 31, 2020
@annieyw annieyw merged commit 24d20fb into angular:master Feb 9, 2021
annieyw pushed a commit that referenced this pull request Feb 9, 2021
@crisbeto @annieyw
fix(tabs): mark tab body as a scrollable container (#16344)
e0782e6 
Since the tab body content can be scrollable and consumers don't have access to the DOM element, we have to mark it as a CdkScrollable in order to allow for overlays inside the tabs to reposition.

Fixes #8405.

(cherry picked from commit 24d20fb)
annieyw pushed a commit that referenced this pull request Feb 9, 2021
@crisbeto @annieyw
fix(tabs): mark tab body as a scrollable container (#16344)
ae642ed 
Since the tab body content can be scrollable and consumers don't have access to the DOM element, we have to mark it as a CdkScrollable in order to allow for overlays inside the tabs to reposition.

Fixes #8405.

(cherry picked from commit 24d20fb)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Mar 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@andrewseguin andrewseguin andrewseguin approved these changes

+1 more reviewer

@danilvalov danilvalov danilvalov approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@andrewseguin andrewseguin

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Scrollable overlays not staying attached when inside tabs
6 participants
@crisbeto @danilvalov @andrewseguin @googlebot @mmalerba @annieyw