Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(button-toggle): clear static aria attributes from host nodes #17086

Merged
merged 1 commit into from Nov 7, 2020
Merged

fix(button-toggle): clear static aria attributes from host nodes #17086

merged 1 commit into from Nov 7, 2020

Conversation

crisbeto
Copy link
Member

Follow-up from #16938. Clears the aria-* attributes from the host node so that they're not duplicated with the underlying input.

@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release labels Sep 14, 2019
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Sep 14, 2019
jelbourn
jelbourn approved these changes Sep 16, 2019
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Sep 16, 2019
@crisbeto
fix(button-toggle): clear static aria attributes from host nodes
1e8f3f6 
Follow-up from angular#16938. Clears the aria-* attributes from the host node so that they're not duplicated with the underlying input.
@crisbeto crisbeto force-pushed the button-toggle-static-aria branch from 639f8c0 to 1e8f3f6 Compare May 2, 2020 15:10
@devversion devversion mentioned this pull request May 29, 2020
Closed
@mmalerba mmalerba removed the lgtm label Jul 31, 2020
@annieyw annieyw merged commit b9756b9 into angular:master Nov 7, 2020
annieyw pushed a commit that referenced this pull request Nov 7, 2020
@crisbeto @annieyw
fix(button-toggle): clear static aria attributes from host nodes (#17086
fab6880 
)

Follow-up from #16938. Clears the aria-* attributes from the host node so that they're not duplicated with the underlying input.

(cherry picked from commit b9756b9)
annieyw pushed a commit that referenced this pull request Nov 7, 2020
@crisbeto @annieyw
fix(button-toggle): clear static aria attributes from host nodes (#17086
783d1ee 
)

Follow-up from #16938. Clears the aria-* attributes from the host node so that they're not duplicated with the underlying input.

(cherry picked from commit b9756b9)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

Assignees

@jelbourn jelbourn

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@crisbeto @jelbourn @googlebot @mmalerba @annieyw