Skip to content

fix(tabs): avoid template type checking errors with Ivy #17228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 1, 2019
Merged

fix(tabs): avoid template type checking errors with Ivy #17228

merged 1 commit into from
Oct 1, 2019

Conversation

crisbeto
Copy link
Member

Along the same lines as #17022. Adds annotations to the various base classes that declare inputs, because the Ivy template type checker doesn't handle base defs at the moment.

Fixes #17121.

@crisbeto
fix(tabs): avoid template type checking errors with Ivy
bff79f1 
Along the same lines as angular#17022. Adds annotations to the various base classes that declare inputs, because the Ivy template type checker doesn't handle base defs at the moment.

Fixes angular#17121.
@crisbeto crisbeto added P2 The issue is important to a large percentage of users, with a workaround target: patch This PR is targeted for the next patch release labels Sep 29, 2019
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Sep 29, 2019
Splaktar
Splaktar approved these changes Sep 29, 2019
View reviewed changes
Copy link
Contributor

@Splaktar Splaktar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Splaktar Splaktar mentioned this pull request Sep 29, 2019
Closed
@crisbeto crisbeto added P1 Impacts a large percentage of users; if a workaround exists it is partial or overly painful and removed P2 The issue is important to a large percentage of users, with a workaround labels Sep 30, 2019
@crisbeto crisbeto added this to the 9.0.0 milestone Sep 30, 2019
jelbourn
jelbourn approved these changes Sep 30, 2019
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Sep 30, 2019
@mmalerba mmalerba merged commit 8c98013 into angular:master Oct 1, 2019
@Splaktar
Copy link
Contributor

Splaktar commented Oct 3, 2019

It looks like _MatTabLinkBase was missed

components/src/material/tabs/tab-nav-bar/tab-nav-bar.ts

Lines 195 to 204 in 8c98013

export class _MatTabLinkBase extends _MatTabLinkMixinBase implements OnDestroy, CanDisable,
CanDisableRipple, HasTabIndex, RippleTarget, FocusableOption {
/** Whether the tab link is active or not. */
protected _isActive: boolean = false;
/** Whether the link is active. */
@Input()
get active(): boolean { return this._isActive; }
set active(value: boolean) {

crisbeto added a commit to crisbeto/material2 that referenced this pull request Oct 3, 2019
@crisbeto
fix(tabs): avoid Ivy template type checking errors in tab link
83ecf4d 
Follow-up from angular#17228. Adds a directive annotation to the `_MatTabLinkBase` because it was overlooked the last time around.
@crisbeto crisbeto mentioned this pull request Oct 3, 2019
Merged
mmalerba pushed a commit that referenced this pull request Oct 3, 2019
@crisbeto @mmalerba
fix(tabs): avoid Ivy template type checking errors in tab link (#17282)
ef5d9cb 
Follow-up from #17228. Adds a directive annotation to the `_MatTabLinkBase` because it was overlooked the last time around.
mmalerba pushed a commit that referenced this pull request Oct 8, 2019
@crisbeto @mmalerba
fix(tabs): avoid template type checking errors with Ivy (#17228)
1bfa1ea 
Along the same lines as #17022. Adds annotations to the various base classes that declare inputs, because the Ivy template type checker doesn't handle base defs at the moment.

Fixes #17121.

(cherry picked from commit 8c98013)
mmalerba pushed a commit that referenced this pull request Oct 8, 2019
@crisbeto @mmalerba
fix(tabs): avoid Ivy template type checking errors in tab link (#17282)
cd11ae5 
Follow-up from #17228. Adds a directive annotation to the `_MatTabLinkBase` because it was overlooked the last time around.

(cherry picked from commit ef5d9cb)
@Splaktar Splaktar mentioned this pull request Oct 10, 2019
Merged
2 tasks
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

@andrewseguin andrewseguin Awaiting requested review from andrewseguin

+1 more reviewer

@Splaktar Splaktar Splaktar approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@jelbourn jelbourn

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P1 Impacts a large percentage of users; if a workaround exists it is partial or overly painful target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
9.0.0
Development

Successfully merging this pull request may close these issues.

tabs(ivy): ivy-ngcc can't handle Inputs from an abstract class w/o a decorator like _MatTabGroupBase
5 participants
@crisbeto @Splaktar @jelbourn @googlebot @mmalerba