Skip to content

fix(material-experimental/checkbox): model value not updated through toggle method #17229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 1, 2019
Merged

fix(material-experimental/checkbox): model value not updated through toggle method #17229

merged 1 commit into from
Oct 1, 2019

Conversation

crisbeto
Copy link
Member

Along the same lines as #11902. When the value of an experimental checkbox is changed through the toggle method it wasn't being propagated to the ControlValueAccessor.

@crisbeto
fix(material-experimental/checkbox): model value not updated through …
d7ca5ab 
…toggle method

Along the same lines as angular#11902. When the value of an experimental checkbox is changed through the `toggle` method it wasn't being propagated to the `ControlValueAccessor`.
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent pr: merge safe target: patch This PR is targeted for the next patch release labels Sep 29, 2019
@crisbeto crisbeto requested a review from mmalerba as a code owner September 29, 2019 15:02
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Sep 29, 2019
@mmalerba mmalerba added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Oct 1, 2019
@mmalerba mmalerba merged commit f178f20 into angular:master Oct 1, 2019
mmalerba pushed a commit that referenced this pull request Oct 8, 2019
@crisbeto @mmalerba
fix(material-experimental/checkbox): model value not updated through …
73b086d 
…toggle method (#17229)

Along the same lines as #11902. When the value of an experimental checkbox is changed through the `toggle` method it wasn't being propagated to the `ControlValueAccessor`.

(cherry picked from commit f178f20)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mmalerba mmalerba mmalerba approved these changes

Assignees

@mmalerba mmalerba

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@crisbeto @mmalerba @googlebot