fix(material-experimental/mdc-form-field): ensure validity styling is not reset by foundation #18266
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devversion
added
P3
googlebot
added
the
cla: yes
… not reset by foundation Currently, whenever the abstract form-field control turns invalid, the text-field foundation does not know about the validity change. Since it refreshes the validity upon focus/blur, it could end up accidentally removing the invalid class. We fix this, by ensuring that the foundation shares the validity state with the one from the form-field control.
devversion
force-pushed
the
fix/madc-form-field-invalid-state
branch
from
2b267bf to
399dfa1
Compare
mmalerba
approved these changes
Jan 23, 2020
mmalerba
added
pr: lgtm
action: merge
yifange
pushed a commit
to yifange/components
that referenced
this pull request
Jan 30, 2020
… not reset by foundation (angular#18266) Currently, whenever the abstract form-field control turns invalid, the text-field foundation does not know about the validity change. Since it refreshes the validity upon focus/blur, it could end up accidentally removing the invalid class. We fix this, by ensuring that the foundation shares the validity state with the one from the form-field control.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, whenever the abstract form-field control turns invalid, the
text-field foundation does not know about the validity change. Since it
refreshes the validity upon focus/blur, it could end up accidentally
removing the invalid class. We fix this, by ensuring that the foundation
shares the validity state with the one from the form-field control.