Skip to content

fix(expansion): disable header height transition if noop animations is set #19373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

devversion
Copy link
Member

We recently refactored the header height transition from Angular
animations to plain CSS (to support density styles).

It looks like this means that we no longer respect the noop animations
module for that animation. This commit fixes that.

…s set

We recently refactored the header height transition from Angular
animations to plain CSS (to support density styles).

It looks like this means that we no longer respect the noop animations
module for that animation. This commit fixes that.
@devversion devversion added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release labels May 15, 2020
@devversion devversion requested a review from jelbourn as a code owner May 15, 2020 16:34
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label May 15, 2020
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added lgtm action: merge The PR is ready for merge by the caretaker labels May 15, 2020
@andrewseguin andrewseguin merged commit 189d98e into angular:master May 18, 2020
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jun 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants