Skip to content

fix(material-experimental/mdc-chips): removing chip on any key press #19425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 5, 2020
Merged

fix(material-experimental/mdc-chips): removing chip on any key press #19425

merged 1 commit into from
Jun 5, 2020

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented May 22, 2020 •
edited
Loading

Currently the MDC-based chip emits the remove event on any key press on the remove button which seems to have regressed in between the various version upgrades and refactors.

@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release labels May 22, 2020
@crisbeto crisbeto requested a review from mmalerba as a code owner May 22, 2020 18:53
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label May 22, 2020
@crisbeto crisbeto mentioned this pull request Jun 2, 2020
Closed
@mmalerba mmalerba added G This is is related to a Google internal issue P2 The issue is important to a large percentage of users, with a workaround lgtm action: merge The PR is ready for merge by the caretaker and removed P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent labels Jun 2, 2020
mmalerba
mmalerba reviewed Jun 2, 2020
View reviewed changes
@crisbeto
fix(material-experimental/mdc-chips): removing chip on any key press
554b81f 
Currently the MDC-based chip emits the `remove` event on any key press on the remove button which seems to have regressed inbetween the different version upgrades and refactors.
@crisbeto crisbeto force-pushed the mdc-chips-any-key-remove branch from 0cf93e3 to 554b81f Compare June 3, 2020 04:06
@jelbourn jelbourn merged commit ee63f63 into angular:master Jun 5, 2020
jelbourn pushed a commit that referenced this pull request Jun 5, 2020
@crisbeto @jelbourn
fix(material-experimental/mdc-chips): removing chip on any key press (#…
50ab109 
…19425)

Currently the MDC-based chip emits the `remove` event on any key press on the remove button which seems to have regressed inbetween the different version upgrades and refactors.
@vanessanschmitt vanessanschmitt mentioned this pull request Jun 12, 2020
Merged
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jul 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mmalerba mmalerba mmalerba left review comments

Assignees

@mmalerba mmalerba

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement G This is is related to a Google internal issue P2 The issue is important to a large percentage of users, with a workaround target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@crisbeto @mmalerba @jelbourn @googlebot