feat(cdk/tree): add trackBy functionality to NestedTreeControl #19602
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
| @@ -196,6 +197,24 @@ describe('CdkNestedTreeControl', () => { | |||
| }); | |||
| }); | |||
| }); | |||
|
|
|||
| it('maintains node expansion state based on trackBy function, if provided', () => { | |||
| const treeControl = new NestedTreeControl<TestData, string>(getChildren); | |||
There was a problem hiding this comment.
Instead of adding the trackBy directly, can you utilize the new constructor options arg here? That would be closer to the implementation we expect users to have
There was a problem hiding this comment.
Sounds good, updated this test to use the options arg. I initially was copying what was done for FlatTreeControl, should I update that test to use FlatTreeControl's options as well?
tjaneczko
changed the title
andrewseguin
approved these changes
Jun 25, 2020
andrewseguin
added
lgtm
action: merge
jelbourn
added
target: minor
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ability to track tree-node expansion via a trackBy function was added to FlatTreeControl in #18708. This PR adds the same functionality to NestedTreeControl to allow nested trees the ability to also specify an alternative method of tracking a node's expansion status.