fix(progress-spinner/testing): harness selector not matching mat-spinner selector #19657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ner selector The progress spinner has two variations: `mat-progress-spinner` and `mat-spinner`, but the test harness was only accounting for the former. Fixes angular#19649.
crisbeto
added
P2
googlebot
added
the
cla: yes
davidlj95
reviewed
Jun 16, 2020
| @@ -14,7 +14,7 @@ import {ProgressSpinnerHarnessFilters} from './progress-spinner-harness-filters' | |||
| /** Harness for interacting with a standard mat-progress-spinner in tests. */ | |||
| export class MatProgressSpinnerHarness extends ComponentHarness { | |||
| /** The selector for the host element of a `MatProgressSpinner` instance. */ | |||
| static hostSelector = 'mat-progress-spinner'; | |||
| static hostSelector = 'mat-progress-spinner,mat-spinner'; | |||
There was a problem hiding this comment.
not sure about that, but I've seen in other harnesses they use an array of selectors when more than one is needed here 🤔
There was a problem hiding this comment.
It seems like the other places have an array and they join it into a comma-separated string so the result should be the same.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The progress spinner has two variations:
mat-progress-spinnerandmat-spinner, but the test harness was only accounting for the former.Fixes #19649.