fix(a11y): list key manager not emitting change event if new item is added to active index #19666
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…added to active index Currently we emit the `ListKeyManager.change` event if the active index changes, but the problem is that the list could be swapped out, resulting in a new item at the same index. These changes switch to using the item reference to determine whether we need to emit the event. Fixes angular#19661.
crisbeto
added
P3
googlebot
added
the
cla: yes
jelbourn
pushed a commit
that referenced
this pull request
Jun 29, 2020
…added to active index (#19666) Currently we emit the `ListKeyManager.change` event if the active index changes, but the problem is that the list could be swapped out, resulting in a new item at the same index. These changes switch to using the item reference to determine whether we need to emit the event. Fixes #19661.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we emit the
ListKeyManager.changeevent if the active index changes, but the problem is that the list could be swapped out, resulting in a new item at the same index. These changes switch to using the item reference to determine whether we need to emit the event.Fixes #19661.