fix(datepicker): not updating calendar state if input changes while open #19973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
P3
googlebot
added
the
cla: yes
mmalerba
reviewed
Jul 14, 2020
| @@ -154,7 +155,7 @@ export class MatDateRangeInput<D> implements MatFormFieldControl<DateRange<D>>, | |||
|
|
|||
| if (newValue !== this._groupDisabled) { | |||
| this._groupDisabled = newValue; | |||
| this._disabledChange.next(this.disabled); | |||
| this._stateChanges.next(); | |||
There was a problem hiding this comment.
Because of upcoming rxjs changes we always want to be passing something to next now, e.g. next(null)
There was a problem hiding this comment.
I changed it to next(undefined) since some of these are implemented due to MatFormFieldControl which requires a stateChanges: Observable<void>.
|
The feedback has been addressed. |
The datepicker was only updating the calendar state that depends on the input when we open and close. I've reworked it so we do it any time one of the input's inputs changes. I also renamed the various `_disabledChange` streams to `_stateChanges` which aligns with what we're doing in other components. Fixes angular#19959.
crisbeto
force-pushed
the
19959/datepicker-state-changes
branch
2 times, most recently
from
40b3dc9
to
07d5152
Compare
wagnermaciel
pushed a commit
that referenced
this pull request
Jul 21, 2020
…pen (#19973) The datepicker was only updating the calendar state that depends on the input when we open and close. I've reworked it so we do it any time one of the input's inputs changes. I also renamed the various `_disabledChange` streams to `_stateChanges` which aligns with what we're doing in other components. Fixes #19959. (cherry picked from commit af6b538)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The datepicker was only updating the calendar state that depends on the input when we open and close. I've reworked it so we do it any time one of the input's inputs changes. I also renamed the various
_disabledChangestreams to_stateChangeswhich aligns with what we're doing in other components.Fixes #19959.