Skip to content

feat(toolbar/testing): Add a test harness for MatToolbar #19976

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jul 17, 2020

Conversation

annieyw
Copy link
Contributor

@annieyw annieyw commented Jul 14, 2020

No description provided.

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jul 14, 2020
@annieyw annieyw marked this pull request as ready for review July 15, 2020 19:01
@annieyw annieyw requested a review from a team as a code owner July 15, 2020 20:47
@mmalerba mmalerba added lgtm action: merge The PR is ready for merge by the caretaker target: minor This PR is targeted for the next minor release labels Jul 15, 2020
Copy link
Contributor

@mmalerba mmalerba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrewseguin andrewseguin merged commit 9e97a34 into angular:master Jul 17, 2020
ngwattcos pushed a commit to ngwattcos/components that referenced this pull request Jul 20, 2020
…9976)

* toolbar harness base

* add get rows as text

* make getRows and getText private

* add public api guard

* refactor getRowsAsText

* use MatToolbarSection instead of literal
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Aug 17, 2020
@annieyw annieyw deleted the toolbar-harness branch August 17, 2020 17:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: minor This PR is targeted for the next minor release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants