Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(datepicker): emitting dateChange event when opposite range input changes #19995

Merged
merged 1 commit into from
Jul 21, 2020
Merged

fix(datepicker): emitting dateChange event when opposite range input changes #19995

merged 1 commit into from
Jul 21, 2020

Conversation

crisbeto
Copy link
Member

Adds some logic to prevent date range inputs from emitting their dateChange and dateInput events when a value is assigned to the opposite input.

Fixes #19968.

@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release labels Jul 15, 2020
@crisbeto crisbeto requested a review from mmalerba as a code owner July 15, 2020 18:48
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jul 15, 2020
@crisbeto crisbeto force-pushed the 19968/datepicker-date-change branch from b80b3cd to 77130ac Compare July 15, 2020 19:05
@crisbeto
fix(datepicker): emitting dateChange event when opposite range input …
e0870a5 
…changes

Adds some logic to prevent date range inputs from emitting their `dateChange` and `dateInput` events when a value is assigned to the opposite input.

Fixes angular#19968.
@crisbeto crisbeto force-pushed the 19968/datepicker-date-change branch from 77130ac to e0870a5 Compare July 15, 2020 20:36
mmalerba
mmalerba approved these changes Jul 15, 2020
View reviewed changes
Copy link
Contributor

@mmalerba mmalerba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmalerba mmalerba added lgtm action: merge The PR is ready for merge by the caretaker labels Jul 15, 2020
@aravindfz aravindfz mentioned this pull request Jul 18, 2020
Closed
@wagnermaciel wagnermaciel merged commit dc245d2 into angular:master Jul 21, 2020
wagnermaciel pushed a commit that referenced this pull request Jul 21, 2020
@crisbeto @wagnermaciel
fix(datepicker): emitting dateChange event when opposite range input …
d383bba 
…changes (#19995)

Adds some logic to prevent date range inputs from emitting their `dateChange` and `dateInput` events when a value is assigned to the opposite input.

Fixes #19968.

(cherry picked from commit dc245d2)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Aug 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mmalerba mmalerba mmalerba approved these changes

Assignees

@mmalerba mmalerba

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug(mat-date-range-picker): updating form control value causes (dateChanged) to emit
4 participants
@crisbeto @mmalerba @googlebot @wagnermaciel