Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cdk-experimental/menu): ensure context menu is closed out with other menu elements on page #20234

Merged
merged 1 commit into from Aug 12, 2020
Merged

fix(cdk-experimental/menu): ensure context menu is closed out with other menu elements on page #20234

merged 1 commit into from Aug 12, 2020

Conversation

andy9775
Copy link
Contributor

@andy9775 andy9775 commented Aug 7, 2020

Fixes an issue which prevents an open context menu from closing out if clicked on a menu bar
element or on an inline menu. Further fixes an issue where opening a context menu does not close
out any open menu.

@andy9775 andy9775 requested a review from jelbourn as a code owner August 7, 2020 14:16
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Aug 7, 2020
@andy9775 andy9775 mentioned this pull request Aug 7, 2020
Merged
jelbourn
jelbourn approved these changes Aug 7, 2020
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added action: merge The PR is ready for merge by the caretaker merge safe target: minor This PR is targeted for the next minor release labels Aug 7, 2020
@andy9775 andy9775 removed the action: merge The PR is ready for merge by the caretaker label Aug 10, 2020
@andy9775 andy9775 force-pushed the cdk-menu-fix-context-menu-close branch from 91da69e to 6241f10 Compare August 10, 2020 14:20
@andy9775 andy9775 requested a review from jelbourn August 10, 2020 14:20
jelbourn
jelbourn reviewed Aug 10, 2020
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rather than polyfilling matches, let's check classList directly.

@andy9775
fix(cdk-experimental/menu): ensure context menu is closed out with ot…
1dee741 
…her menu elements on page

Fixes an issue which prevents an open context menu from closing out if clicked on a menu bar
element or on an inline menu. Further fixes an issue where opening a context menu does not close
out any open menu.
@andy9775 andy9775 force-pushed the cdk-menu-fix-context-menu-close branch from 6241f10 to 1dee741 Compare August 10, 2020 16:29
@andy9775
Copy link
Contributor Author

@jelbourn feedback should be addressed

@jelbourn jelbourn added the action: merge The PR is ready for merge by the caretaker label Aug 10, 2020
@andrewseguin andrewseguin merged commit beaf072 into angular:master Aug 12, 2020
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

@teflonwaffles teflonwaffles Awaiting requested review from teflonwaffles

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: minor This PR is targeted for the next minor release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@andy9775 @jelbourn @googlebot @andrewseguin