fix(expansion): enforce stricter types for inputs

[rafaelss95]

No description provided.

[crisbeto]

The whole point of using coercion here is that you can pass in anything. The problem is that TS doesn't support different types for the getter and the setter.

[rafaelss95]

Yep, I know. And I'm aware this is a breaking change and I wouldn't expect it to be merged until you reach v11 stages.

[crisbeto]

If we were actually requiring these to be boolean, the coerceBooleanProperty call becomes redundant. I think that changing this defeats the purpose and we'd have to do it across the entire codebase.

[rafaelss95]

You do actually use boolean for all boolean accessors, these here modified in this PR are outside the rule. It helps not only documentation, but the dev experience when accessing a getter, for example, you'd want a boolean, not any.

See these two examples for reference:

components/src/material/expansion/expansion-panel.ts

Lines 107 to 113 in cb8de61

	@Input()
	get hideToggle(): boolean {
	return this._hideToggle || (this.accordion && this.accordion.hideToggle);
	}
	set hideToggle(value: boolean) {
	this._hideToggle = coerceBooleanProperty(value);
	}

components/src/cdk/drag-drop/directives/drop-list-group.ts

Lines 36 to 41 in cfe37d1

	@Input('cdkDropListGroupDisabled')
	get disabled(): boolean { return this._disabled; }
	set disabled(value: boolean) {
	this._disabled = coerceBooleanProperty(value);
	}
	private _disabled = false;

[jelbourn]

LGTM- we'll find out how breaking this is inside Google once we get closer to v11

[jelbourn]

Caretaker note: Don't merge until v11 release train

[jelbourn]

@rafaelss95 could you add a "BREAKING CHANGE" note to the commit message?

[rafaelss95]

@rafaelss95 could you add a "BREAKING CHANGE" note to the commit message?

Let me know if it's fine now.

[jelbourn]

@rafaelss95 just checked- the commit has to be a fix to show up in the changelog. You can also search (with /) through git log to see examples of other breaking changes blocks

[rafaelss95]

@jelbourn It should be ok now.

[rafaelss95]

@annieyw is there any chance to merge this before v12? :)

[angular-automatic-lock-bot]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}