Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(material/table): rename flex example #20316

Merged
merged 1 commit into from Aug 18, 2020
Merged

fix(material/table): rename flex example #20316

merged 1 commit into from Aug 18, 2020

Conversation

andrewseguin
Copy link
Contributor

The flex example currently shows up at the top of the examples lists because it is alphabetically higher. This renames it so that it appears lower down the list. Now the first example should correctly be the basic <table mat-table>

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Aug 14, 2020
@andrewseguin andrewseguin added merge safe P2 The issue is important to a large percentage of users, with a workaround labels Aug 14, 2020
mmalerba
mmalerba approved these changes Aug 14, 2020
View reviewed changes
Copy link
Contributor

@mmalerba mmalerba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmalerba mmalerba added the action: merge The PR is ready for merge by the caretaker label Aug 14, 2020
@mmalerba
Copy link
Contributor

zzz flex table example

jelbourn
jelbourn approved these changes Aug 14, 2020
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added the target: patch This PR is targeted for the next patch release label Aug 15, 2020
@wagnermaciel wagnermaciel merged commit 3396b4b into angular:master Aug 18, 2020
wagnermaciel pushed a commit that referenced this pull request Aug 18, 2020
@andrewseguin @wagnermaciel
fix(material/table): rename flex example (#20316)
be244f2 
(cherry picked from commit 3396b4b)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

@mmalerba mmalerba mmalerba approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P2 The issue is important to a large percentage of users, with a workaround target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@andrewseguin @mmalerba @jelbourn @googlebot @wagnermaciel