refactor: add support for TypeScript 4.0 #20368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
alan-agius4
changed the title
alan-agius4
requested review from
andrewseguin,
crisbeto,
devversion,
jelbourn and
mmalerba
as code owners
devversion
reviewed
Aug 20, 2020
crisbeto
reviewed
Aug 20, 2020
jelbourn
reviewed
Aug 20, 2020
devversion
approved these changes
Aug 21, 2020
devversion
reviewed
Aug 21, 2020
alan-agius4
requested review from
jelbourn
and removed request for
jelbourn,
andrewseguin and
mmalerba
alan-agius4
added
the
target: minor
jelbourn
reviewed
Aug 24, 2020
|
Thanks @devversion & @jelbourn for the input and feedback. I’ll be doing the changes tomorrow. |
alan-agius4
changed the title
|
@devversion & @jelbourn PTAL. Thanks. |
With this change we refactor the code to support compilation using TS 4.0. The main changes are: 1) Refactor tests to not delete non optional properties 2) Refactor components not to override properties with accessors and vice-versa which is now not permitted. https://devblogs.microsoft.com/typescript/announcing-typescript-4-0-beta/#breaking-changes
… to 10.1.0-next.8
jelbourn
approved these changes
Aug 25, 2020
jelbourn
added
action: merge
devversion
approved these changes
Aug 25, 2020
annieyw
pushed a commit
to annieyw/components
that referenced
this pull request
Aug 31, 2020
With this change we refactor the code to support compilation using TS 4.0. 1) Refactor tests to not delete non optional properties 2) Refactor components not to override properties with accessors and vice-versa which is now not permitted. https://devblogs.microsoft.com/typescript/announcing-typescript-4-0-beta/#breaking-changes 3) update typescript to 4.0, tslint to 6.1.3 and angular packages to 10.1.0-next.8 4) add ts-compat integration test for TypeScript 3.9
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change we refactor the code to support compilation using TS 4.0.
The main changes are: