fix(cdk/table): resolve breaking constructor changes #20425
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
P2
googlebot
added
the
cla: yes
crisbeto
force-pushed
the
20422/table-breaking-changes
branch
from
4c6a169 to
89dfb79
Compare
crisbeto
commented
Aug 26, 2020
|
Can you say fixed rather than reverted? From the description I was worried that the optimizations were being rolled back but I see that’s not the case.
… On Aug 26, 2020, at 4:08 PM, Kristiyan Kostadinov ***@***.***> wrote:
In #19964 and #19750 some breaking constructor changes were made which eventually got released as a part of a patch branch which doesn't follow our breaking changes policy.
These changes make the new constructor parameters optional and add fallbacks to the old behavior.
Fixes #20422.
cc @kseamon @MichaelJamesParsons
You can view, comment on, or merge this pull request online at:
#20425
Commit Summary
fix(cdk/table): revert breaking constructor changes
File Changes
M src/cdk/table/sticky-styler.ts (27)
M src/cdk/table/table.ts (18)
M tools/public_api_guard/cdk/table.d.ts (12)
Patch Links:
https://github.com/angular/components/pull/20425.patch
https://github.com/angular/components/pull/20425.diff
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
|
LGTM, thanks for looking into this! |
crisbeto
force-pushed
the
20422/table-breaking-changes
branch
from
89dfb79 to
890ee3f
Compare
crisbeto
changed the title
devversion
approved these changes
Aug 27, 2020
crisbeto
force-pushed
the
20422/table-breaking-changes
branch
3 times, most recently
from
44e8fe2 to
b4de554
Compare
In angular#19964 and angular#19750 some breaking constructor changes were made which eventually got released as a part of a patch branch which doesn't follow our breaking changes policy. These changes make the new constructor parameters optional and add fallbacks to the old behavior. Fixes angular#20422.
crisbeto
force-pushed
the
20422/table-breaking-changes
branch
from
b4de554 to
60a79b3
Compare
kyubisation
added a commit
to sbb-design-systems/sbb-angular
that referenced
this pull request
Sep 15, 2020
The Angular CDK introduced a breaking change in version 10.1.2 and again in 10.2.0, which was fixed in 10.2.1: angular/components#20425 Since we adapted to the 10.1.2 change, we also need to adapt to the 10.2.0 change.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #19964 and #19750 some breaking constructor changes were made which eventually got released as a part of a patch branch which doesn't follow our breaking changes policy.
These changes make the new constructor parameters optional and add fallbacks to the old behavior.
Fixes #20422.
cc @kseamon @MichaelJamesParsons