-
Notifications
You must be signed in to change notification settings - Fork 6.8k
feat(datepicker): add viewChanged output to calendar (#13759) #20468
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@googlebot I signed it! |
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
ee907d6
to
7b1c1a0
Compare
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
7b1c1a0
to
06baa01
Compare
src/material/datepicker/calendar.ts
Outdated
@@ -299,6 +305,9 @@ export class MatCalendar<D> implements AfterContentInit, AfterViewChecked, OnDes | |||
/** Whether the calendar is in month view. */ | |||
get currentView(): MatCalendarView { return this._currentView; } | |||
set currentView(value: MatCalendarView) { | |||
if (this._currentView !== value) { | |||
this.viewChanged.emit(value); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we emit here, the event will come before the UI has actually updated. I think people would expect this event to come after the view has updated. I think a Promise.resolve().then()
should make this emit after, if not maybe a setTimeout()
. Please also add a test that verifies this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Event emitters have an isAsync
flag which we could use here? E.g. new EventEmitter(true)
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fhuschle can you try removing the setTimeout
and passing true
when constructing the EventEmitter
? If that works we should use it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That seems to work the same way.
06baa01
to
1547aee
Compare
- replace deprecated async with waitForAsync
1547aee
to
26d6ef0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Adds viewChanged output to calendar so you can react if the view changed between 'month' | 'year' | 'multi-year'.
Fixes #13759.