fix(material/datepicker): add close button for screen readers #20666
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
P3
googlebot
added
the
cla: yes
mmalerba
reviewed
Sep 30, 2020
| type="button" | ||
| mat-raised-button | ||
| color="primary" | ||
| class="mat-datepicker-close-button" |
There was a problem hiding this comment.
can this just be .cdk-visually-hidden instead?
There was a problem hiding this comment.
The mat-datepicker-close-button class is used to position the button under the calendar. It's toggling cdk-visually-hidden above to show/hide the button.
Adds an invisible close button for screen reader users that becomes visible when the user tabs into it. Fixes angular#14379.
crisbeto
force-pushed
the
14379/datepicker-close-button
branch
from
6afce18 to
f726766
Compare
crisbeto
added
target: minor
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an invisible close button for screen reader users that becomes visible when the user tabs into it.
Note: there was a PR did was doing this already (#14429), but the feedback on it was never addressed and there hasn't been any activity on it in nearly 2 years.
Fixes #14379.