Skip to content

fix(material/datepicker): lifecycle hooks not being called #20700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 7, 2020
Merged

fix(material/datepicker): lifecycle hooks not being called #20700

merged 2 commits into from
Oct 7, 2020

Conversation

mmalerba
Copy link
Contributor

@mmalerba mmalerba commented Oct 1, 2020

Lifecycle hooks are not being called in some cases due to a weird
interaction between extending TS mixins, running in view engine, and
transpiling the code with tsickle.

@mmalerba
fix(material/datepicker): lifecycle hooks not being called
4d400e5 
Lifecycle hooks are not being called in some cases due to a weird
interaction between extending TS mixins, running in view engine, and
transpiling the code with tsickle.
@mmalerba mmalerba added P2 The issue is important to a large percentage of users, with a workaround G This is is related to a Google internal issue target: patch This PR is targeted for the next patch release area: material/datepicker labels Oct 1, 2020
@mmalerba mmalerba requested a review from annieyw October 1, 2020 17:43
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Oct 1, 2020
annieyw
annieyw approved these changes Oct 1, 2020
View reviewed changes
Copy link
Contributor

@annieyw annieyw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm but api check is failing

@mmalerba mmalerba added the action: merge The PR is ready for merge by the caretaker label Oct 1, 2020
@wagnermaciel wagnermaciel merged commit b59e4a1 into angular:master Oct 7, 2020
wagnermaciel pushed a commit that referenced this pull request Oct 7, 2020
@mmalerba @wagnermaciel
fix(material/datepicker): lifecycle hooks not being called (#20700)
6318389 
* fix(material/datepicker): lifecycle hooks not being called

Lifecycle hooks are not being called in some cases due to a weird
interaction between extending TS mixins, running in view engine, and
transpiling the code with tsickle.

* test(material/datepicker): fix api guard tests

(cherry picked from commit b59e4a1)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
1 more reviewer

@annieyw annieyw annieyw approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@annieyw annieyw

Labels
action: merge The PR is ready for merge by the caretaker area: material/datepicker cla: yes PR author has agreed to Google's Contributor License Agreement G This is is related to a Google internal issue P2 The issue is important to a large percentage of users, with a workaround target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mmalerba @annieyw @googlebot @wagnermaciel