Skip to content

fix(material/button): add more prominent focus indication in high contrast mode #20821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 20, 2020
Merged

fix(material/button): add more prominent focus indication in high contrast mode #20821

merged 1 commit into from
Oct 20, 2020

Conversation

crisbeto
Copy link
Member

We currently have some focus indication in high contrast mode, but it's very difficult to see. These changes replace the old one with a 3x thicker outline.

Fixes #20820.

cc @mikzat

For reference:
Angular_Material_-_Internet_Explorer_2020-10-17_11-07-53

@crisbeto
fix(material/button): add more prominent focus indication in high con…
aed4ce0 
…trast mode

We currently have some focus indication in high contrast mode, but it's very
difficult to see. These changes replace the old one with a 3x thicker outline.

Fixes angular#20820.
@crisbeto crisbeto added P2 The issue is important to a large percentage of users, with a workaround Accessibility This issue is related to accessibility (a11y) target: patch This PR is targeted for the next patch release labels Oct 17, 2020
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Oct 17, 2020
jelbourn
jelbourn approved these changes Oct 19, 2020
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added the action: merge The PR is ready for merge by the caretaker label Oct 19, 2020
@jelbourn jelbourn merged commit 345ad70 into angular:master Oct 20, 2020
jelbourn pushed a commit that referenced this pull request Oct 20, 2020
@crisbeto @jelbourn
fix(material/button): add more prominent focus indication in high con…
1c39b72 
…trast mode (#20821)

We currently have some focus indication in high contrast mode, but it's very
difficult to see. These changes replace the old one with a 3x thicker outline.

Fixes #20820.

(cherry picked from commit 345ad70)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

@andrewseguin andrewseguin Awaiting requested review from andrewseguin

Assignees

@jelbourn jelbourn

Labels
Accessibility This issue is related to accessibility (a11y) action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P2 The issue is important to a large percentage of users, with a workaround target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug(mat-button): Button focus is imperceptible in high-contrast mode
2 participants
@crisbeto @jelbourn