Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(material-experimental/mdc-chips): use MDC-based form field #20880

Merged
merged 1 commit into from Nov 4, 2020
Merged

fix(material-experimental/mdc-chips): use MDC-based form field #20880

merged 1 commit into from Nov 4, 2020

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Oct 25, 2020 •
edited

  • Changes the MDC chips module to depend on the MDC form field module since we generally don't support mixing MDC and non-MDC components.
  • Fixes that the MDC chip input didn't work inside of an MDC form field.
  • Switches the MDC chips demo to use mostly MDC components.
  • Fixes some tests that broke after the switch to the MDC form field.

@vanessanschmitt was it intentional that the MDC chips depend on the non-MDC form field or is it a side-effect of the MDC form field not being available when the chips were introduced?

@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release labels Oct 25, 2020
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Oct 25, 2020
@crisbeto
fix(material-experimental/mdc-chips): use MDC-based form field
a78f432 
* Changes the MDC chips module to depend on the MDC form field module since we generally
don't support mixing MDC and non-MDC components.
* Fixes that the MDC chip input didn't work inside of an MDC form field.
* Switches the MDC chips demo to use mostly MDC components.
* Fixes some tests that broke after the switch to the MDC form field.
@jelbourn jelbourn added P2 The issue is important to a large percentage of users, with a workaround and removed P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent labels Oct 26, 2020
jelbourn
jelbourn approved these changes Oct 26, 2020
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added the action: merge The PR is ready for merge by the caretaker label Oct 26, 2020
@annieyw annieyw added target: minor This PR is targeted for the next minor release and removed target: patch This PR is targeted for the next patch release labels Nov 4, 2020
@annieyw annieyw merged commit 7596532 into angular:master Nov 4, 2020
@mmalerba mmalerba added P2 The issue is important to a large percentage of users, with a workaround and removed P2 The issue is important to a large percentage of users, with a workaround labels Nov 13, 2020
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

@mmalerba mmalerba Awaiting requested review from mmalerba

Assignees

@mmalerba mmalerba

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P2 The issue is important to a large percentage of users, with a workaround target: minor This PR is targeted for the next minor release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@crisbeto @jelbourn @mmalerba @annieyw