Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(material/datepicker): range input emitters not picked up by language service #20937

Merged
merged 1 commit into from Nov 4, 2020
Merged

fix(material/datepicker): range input emitters not picked up by language service #20937

merged 1 commit into from Nov 4, 2020

Conversation

crisbeto
Copy link
Member

The dateChange and dateInput outputs are inherited through a mixin which seems to prevent the language service from picking them up. These changes add extra hints to the component metadata.

Fixes #20932.

@crisbeto
fix(material/datepicker): range input emitters not picked up by langu…
4d39e11 
…age service

The `dateChange` and `dateInput` outputs are inherited through a mixin which
seems to prevent the language service from picking them up. These changes
add extra hints to the component metadata.

Fixes angular#20932.
@crisbeto crisbeto added P4 A relatively minor issue that is not relevant to core functions target: patch This PR is targeted for the next patch release labels Oct 30, 2020
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Oct 30, 2020
mmalerba
mmalerba approved these changes Oct 30, 2020
View reviewed changes
Copy link
Contributor

@mmalerba mmalerba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmalerba mmalerba added the action: merge The PR is ready for merge by the caretaker label Oct 30, 2020
@annieyw annieyw merged commit 57a3661 into angular:master Nov 4, 2020
annieyw pushed a commit that referenced this pull request Nov 4, 2020
@crisbeto @annieyw
fix(material/datepicker): range input emitters not picked up by langu…
63d9364 
…age service (#20937)

The `dateChange` and `dateInput` outputs are inherited through a mixin which
seems to prevent the language service from picking them up. These changes
add extra hints to the component metadata.

Fixes #20932.

(cherry picked from commit 57a3661)
annieyw pushed a commit that referenced this pull request Nov 4, 2020
@crisbeto @annieyw
fix(material/datepicker): range input emitters not picked up by langu…
35f494c 
…age service (#20937)

The `dateChange` and `dateInput` outputs are inherited through a mixin which
seems to prevent the language service from picking them up. These changes
add extra hints to the component metadata.

Fixes #20932.

(cherry picked from commit 57a3661)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mmalerba mmalerba mmalerba approved these changes

Assignees

@mmalerba mmalerba

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P4 A relatively minor issue that is not relevant to core functions target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
3 participants
@crisbeto @mmalerba @annieyw