Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(material/datepicker): don't invoke change handler when filter is swapped out if result is the same #20970

Merged
merged 1 commit into from
Nov 24, 2020
Merged

fix(material/datepicker): don't invoke change handler when filter is swapped out if result is the same #20970

merged 1 commit into from
Nov 24, 2020

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Nov 5, 2020

Doesn't invoke the ControlValueAccessor change function when a new date filter is assigned, if the result wouldn't have change the validation state.

Fixes #20967.

@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release labels Nov 5, 2020
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Nov 5, 2020
@crisbeto crisbeto mentioned this pull request Nov 5, 2020
Closed
mmalerba
mmalerba approved these changes Nov 5, 2020
View reviewed changes
Copy link
Contributor

@mmalerba mmalerba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/material/datepicker/datepicker-input.ts Outdated Show resolved Hide resolved
@crisbeto
fix(material/datepicker): don't invoke change handler when filter is …
661f182 
…swapped out if result is the same

Doesn't invoke the `ControlValueAccessor` change function when a new date filter
is assigned, if the result wouldn't have change the validation state.

Fixes angular#20967.
@crisbeto crisbeto force-pushed the 20967/datepicker-filter-change branch from d2e2ecb to 661f182 Compare November 6, 2020 05:46
@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Nov 6, 2020
@annieyw annieyw merged commit 975fbb3 into angular:master Nov 24, 2020
annieyw pushed a commit that referenced this pull request Nov 24, 2020
@crisbeto @annieyw
fix(material/datepicker): don't invoke change handler when filter is …
ee78609 
…swapped out if result is the same (#20970)

Doesn't invoke the `ControlValueAccessor` change function when a new date filter
is assigned, if the result wouldn't have change the validation state.

Fixes #20967.

(cherry picked from commit 975fbb3)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mmalerba mmalerba mmalerba approved these changes

Assignees

@mmalerba mmalerba

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug(mat-datepicker): value change firing on filter re assign
3 participants
@crisbeto @mmalerba @annieyw