fix(material/datepicker): range input controls dirty on init #21223
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
P2
google-cla
bot
added
the
cla: yes
Fixes that the date range input controls were marking each other as dirty on initialization. This seems like an easy fix on the surface, but it's somewhat tricky, because while we usually don't want the inputs to respond each other's events, we still want it to happen if an end date before the start date is assigned. These changes resolve the issue by not having the inputs respond to any events from inside the input, but notify each other when a value is assigned programmatically. I've also cleaned up some unnecessary code and added more test cases for things that tripped me up while fixing the issue. Fixes angular#20213.
crisbeto
force-pushed
the
20213/date-range-dirty-on-init
branch
from
dcc63ec to
66ecb5b
Compare
annieyw
added
target: minor
wagnermaciel
pushed a commit
to wagnermaciel/components
that referenced
this pull request
Jan 14, 2021
…#21223) Fixes that the date range input controls were marking each other as dirty on initialization. This seems like an easy fix on the surface, but it's somewhat tricky, because while we usually don't want the inputs to respond each other's events, we still want it to happen if an end date before the start date is assigned. These changes resolve the issue by not having the inputs respond to any events from inside the input, but notify each other when a value is assigned programmatically. I've also cleaned up some unnecessary code and added more test cases for things that tripped me up while fixing the issue. Fixes angular#20213.
|
Is there any way to use this fix? I'm using Angular 11 and just updated Angular Material to 11.0.4 :) |
|
The fix is in the 11.1.0 release. You can either update to the RC version that is already out or wait until the stable version is released. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes that the date range input controls were marking each other as dirty on initialization. This seems like an easy fix on the surface, but it's somewhat tricky, because while we usually don't want the inputs to respond each other's events, we still want it to happen if an end date before the start date is assigned.
These changes resolve the issue by not having the inputs respond to any events from inside the input, but notify each other when a value is assigned programmatically.
I've also cleaned up some unnecessary code and added more test cases for things that tripped me up while fixing the issue.
Fixes #20213.