Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(material-experimental/mdc-slide-toggle): add class to mdc-switch element #21284

Merged
merged 1 commit into from Dec 14, 2020
Merged

fix(material-experimental/mdc-slide-toggle): add class to mdc-switch element #21284

merged 1 commit into from Dec 14, 2020

Conversation

andrewseguin
Copy link
Contributor

Required for internal styling so that we can target the mdc-switch element without using the .mdc-switch target

@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Dec 11, 2020
crisbeto
crisbeto approved these changes Dec 11, 2020
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I think that the same can be achieved by targeting .mat-slide-toggle .mdc-switch.

@andrewseguin
Copy link
Contributor Author

Yeah, the problem is that we've got lint rules internally that disallow targeting .mdc-. It doesn't necessary apply to us, but more to keep clients from trying to override styles. We try to avoid it anyways

@andrewseguin andrewseguin added the target: patch This PR is targeted for the next patch release label Dec 11, 2020
jelbourn
jelbourn approved these changes Dec 11, 2020
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added action: merge The PR is ready for merge by the caretaker P2 The issue is important to a large percentage of users, with a workaround labels Dec 11, 2020
@mmalerba mmalerba merged commit 5cc9601 into angular:master Dec 14, 2020
mmalerba pushed a commit that referenced this pull request Dec 14, 2020
@andrewseguin @mmalerba
fix(material-experimental/mdc-slide-toggle): add class to mdc-switch …
0266db2 
…element (#21284)

(cherry picked from commit 5cc9601)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jan 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

@crisbeto crisbeto crisbeto approved these changes

@mmalerba mmalerba Awaiting requested review from mmalerba

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P2 The issue is important to a large percentage of users, with a workaround target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@andrewseguin @jelbourn @crisbeto @mmalerba