fix(material-experimental/mdc-list): make internal input non-interactive #21438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
P3
google-cla
bot
added
the
cla: yes
mmalerba
reviewed
Jan 5, 2021
|
We should probably not bother with this change since MDC is rewriting their list from scratch (to be more like our's with different variants) |
Due to how MDC's checkbox styles are set up, we always have to keep an `input` inside the `mat-list-option`, however our current setup where we only set `tabindex="-1"` on it is invalid, because the input is still interactive either through clicking on it, or by using a screen reader's forms mode. These changes completely remove the input from the accessibility model by setting it to `display: none`.
crisbeto
force-pushed
the
mdc-list-internal-input
branch
from
4880a5e
to
9d2b8c6
Compare
|
@jelbourn I'm not familiar with what their new list will look like, but I think that we'll have to keep doing this if we're projecting in a checkbox |
|
That's fair |
annieyw
pushed a commit
that referenced
this pull request
Jan 9, 2021
…ive (#21438) Due to how MDC's checkbox styles are set up, we always have to keep an `input` inside the `mat-list-option`, however our current setup where we only set `tabindex="-1"` on it is invalid, because the input is still interactive either through clicking on it, or by using a screen reader's forms mode. These changes completely remove the input from the accessibility model by setting it to `display: none`. (cherry picked from commit c268246)
wagnermaciel
pushed a commit
to wagnermaciel/components
that referenced
this pull request
Jan 14, 2021
…ive (angular#21438) Due to how MDC's checkbox styles are set up, we always have to keep an `input` inside the `mat-list-option`, however our current setup where we only set `tabindex="-1"` on it is invalid, because the input is still interactive either through clicking on it, or by using a screen reader's forms mode. These changes completely remove the input from the accessibility model by setting it to `display: none`.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to how MDC's checkbox styles are set up, we always have to keep an
inputinside themat-list-option, however our current setup where we only settabindex="-1"on it is invalid, because the input is still interactive either through clicking on it, or by using a screen reader's forms mode.These changes completely remove the input from the accessibility model by setting it to
display: none.